#269 (test and deploy)

39 · by Luc Saffre · in Developers · assigned to Luc Saffre

Kurzbeschreibung

Review test suites after a series of changes. Get Lino test suites to pass on GitLab CI

Kinder

#5907 (pm prep says "can't set attribute 'string'") (by Luc Saffre in Developers assigned to Luc Saffre)
#4898 (Change "site operator" to "site owner". Add a field site_maintainer and render them in the local help pages.) (by Luc Saffre in Developers assigned to Luc Saffre)
#5098 (pm prep should remove media files) (by Luc Saffre in Developers assigned to Luc Saffre)
#5510 (make_code.py for synodal) (by Luc Saffre in Developers assigned to Luc Saffre)
#5619 (redis on gitlab) (by Luc Saffre in Developers)
#5908 (fdf() now adds a comma on GL) (by Luc Saffre in Developers assigned to Sharif Mehedi)

Kommentare

2 Wochen, 2 Tage ago von Sharif Mehedi about #269 (test and deploy) : And CTRL+S works on action dialog.
2 Wochen, 2 Tage ago von Sharif Mehedi about #269 (test and deploy) : Jane and vjane is now back after upgrade, there were no need for restore.
2 Wochen, 2 Tage ago von Sharif Mehedi about #269 (test and deploy) : I am shutting down jane, for an upgrade.
2 Wochen, 2 Tage ago von Sharif Mehedi about #269 (test and deploy) : I will now release the relevant packages to pypi and upgrade jane & vjane.
2 Wochen, 5 Tage ago von Luc Saffre Antwort auf Sharif Mehedi about #269 (test and deploy) : A historical day! I replied in vjane.
2 Wochen, 5 Tage ago von Sharif Mehedi about #269 (test and deploy) (1 Antwort) : vjane is also active and working. I made this comment from vjane.
2 Wochen, 5 Tage ago von Sharif Mehedi about #269 (test and deploy) : Jane is back after the upgrade. It was quick because I didn't have to run restore.py because diff snapshot/restore.py t/restore.py gave nothing.
2 Wochen, 5 Tage ago von Sharif Mehedi about #269 (test and deploy) : I will shutdown jane now, seems like nobody's working at the moment, and feels safe to go ahead.
3 Wochen, 5 Tage ago von Luc Saffre about #269 (test and deploy) : Also Uploads.disabled_fields() disables the camera_stream action only when ar.renderer.lino_web_template.endswith('.json'), which causes a doctest failure in welfare.
3 Wochen, 5 Tage ago von Luc Saffre Antwort auf Sharif Mehedi about #269 (test and deploy) : Indeed, the if ar.renderer.lino_web_template.endswith(".json") looks suspicious.
3 Wochen, 6 Tage ago von Sharif Mehedi Antwort auf Luc Saffre about #269 (test and deploy) (1 Antwort) : I think it's coming from the submit detail action
3 Wochen, 6 Tage ago von Luc Saffre about #269 (test and deploy) (1 Antwort) : pm test is failing in avanti1 for test_nullchar.py and I have no idea why.
Items in the first set but not the second: 'eval_js' Items in the second set but not the first: 'data_record'
3 Wochen, 6 Tage ago von Luc Saffre about #269 (test and deploy) : The DocTestFailure in /builds/lino-framework/book/docs/specs/calview.rst:382 is from my optimization of the cal.rst docs.
3 Wochen, 6 Tage ago von Luc Saffre about #269 (test and deploy) : Jane is back after the upgrade.
3 Wochen, 6 Tage ago von Luc Saffre about #269 (test and deploy) : I will soon update jane and maybe froinde, in order to test the recent changes in the front end.
1 Monat, 3 Wochen ago von Luc Saffre about #269 (test and deploy) : I released react to pypi because some test suites on GL failed because react still tried to import things from lino_extjs, e.g. gitlab.com/synodalsoft/patrols/-/jobs/16207353384
1 Monat, 3 Wochen ago von Luc Saffre about #269 (test and deploy) : The patrols CI on GL reported "AttributeError: module 'lino.core.constants' has no attribute 'TOOLBAR_VISIBILITY_HIDDEN'" because it uses the pypi version of lino. So I released lino to PyPI.
2 Monate ago von Luc Saffre about #269 (test and deploy) : I wrote some tests to cover the assertEquivalent() method, and as a side effect moved this method and its tests from lino to atelier because this feature is independent of Lino. As a side effect I will need to release atelier to PyPI and there is a risk of having test failures when a developer didn'...
2 Monate ago von Luc Saffre about #269 (test and deploy) : I extended the assertEquivalent() method to support ellipsis. Needed this for the two test_notify.py in noi1e and noi1r.
2 Monate ago von Luc Saffre about #269 (test and deploy) : This failure in presto on GitLab was because of the message "You must set include-system-site-packages = true in your pyvenv.cfg file", which was emitted by the xl/lino_xl/lib/appypod/appy_renderer.py module. This message was indeed at the wrong place. I now changed it into an Warning raised when th...
2 Monate, 1 Woche ago von Sharif Mehedi about #269 (test and deploy) : Jane is now back again after the upgrade.
2 Monate, 1 Woche ago von Sharif Mehedi about #269 (test and deploy) : I am shutting down jane to go forward with the upgrade.
2 Monate, 1 Woche ago von Sharif Mehedi about #269 (test and deploy) : I released lino, noi & react to pypi. But got stuck with jane server password. I seem to have lost it again. I couldn't find an entry on my password database. So the upgrade got delayed.
2 Monate, 1 Woche ago von Sharif Mehedi about #269 (test and deploy) : I am going to shutoff jane for a moment to upgrade it.
3 Monate, 1 Woche ago von Sharif Mehedi about #269 (test and deploy) : I published some changes in lino, xl and book.
4 Monate ago von Luc Saffre about #269 (test and deploy) : todo next: notify other guests of an event when somebody enrolls. Add comments and tickets by event.
4 Monate ago von Luc Saffre about #269 (test and deploy) : I pushed a few minor changes in lino, xl, book, welfare, ...
4 Monate, 2 Wochen ago von Luc Saffre about #269 (test and deploy) : I started adapting the book doctests after my recent changes.
4 Monate, 3 Wochen ago von Luc Saffre Antwort auf Luc Saffre about #269 (test and deploy) : There were only two doctest snippets in the ug that were worth begin tested, and they were actually a single snippet. I moved this snippet to a section Quick search fields in the dg, which refers to the end-user docs it verifies.
My current rule: the User Guide should not contain any doctest snippet...
4 Monate, 3 Wochen ago von Luc Saffre about #269 (test and deploy) (1 Antwort) : The failure in ug on GitLab is because a few weeks ago I moved a series of doctests from the book to the ug. Maybe this was a bad idea: these doctests require the demo projects of the book. I see 3 possible directions: Install the book on GL when testing ug Move these doctests back from the ug to t...
4 Monate, 3 Wochen ago von Luc Saffre Antwort auf Luc Saffre about #269 (test and deploy) : I pushed a one-line change "Review gitlab-ci Python version" to almost all our repositories. Python 3.11 is the oldest supported Python version and most tests on GitLab run with this. The book repository also runs the tests a second time with Python 3.14 (the youngest supported Python version).
4 Monate, 3 Wochen ago von Luc Saffre Antwort auf Luc Saffre about #269 (test and deploy) : Oops, these failures in the book suite are not in Python 3.10 but Python 3.11. So there *is* a good reason to do this work: some of our own servers.
4 Monate, 3 Wochen ago von Luc Saffre Antwort auf Luc Saffre about #269 (test and deploy) : I should review the .gitlab-ci.yml of all repositories for their python version:
find -name .gitlab-ci.yml -exec grep -H "image:" {} \; ./amici/.gitlab-ci.yml:image: python:3.12 ./avanti/.gitlab-ci.yml:image: python:3.10 ./ss/.gitlab-ci.yml:#image: python:3.7-alpine ./ss/.gitlab-ci.yml:#image: debia...
4 Monate, 3 Wochen ago von Luc Saffre about #269 (test and deploy) (3 Antworten) : I pushed yet another small change to make our test suite backwards-compatible to Python 3.10 (after this). It's rather improbable that anybody will ever be grateful for this work. The oldest customer-hosted production sites maintained by Synodalsoft are running Python 3.7.3, so anyway they wouldn't ...
5 Monate ago von Luc Saffre Antwort auf Luc Saffre about #269 (test and deploy) : Took me more than half an hour to optimize this test.
5 Monate ago von Luc Saffre about #269 (test and deploy) (1 Antwort) : doctest docs/specs/polls.rst is failing on GL py311 (not py313).
5 Monate ago von Luc Saffre about #269 (test and deploy) : Jane is back with the newest version.
5 Monate ago von Luc Saffre about #269 (test and deploy) : I will upgrade Jane now soon. Probably also froinde and ets.
5 Monate, 1 Woche ago von Luc Saffre Antwort auf Luc Saffre about #269 (test and deploy) : My change also caused two doctest failures in book.
5 Monate, 1 Woche ago von Luc Saffre Antwort auf Luc Saffre about #269 (test and deploy) : This caused my to discover and fix yet another subtle bug: "inv install -b" created an empty requirements-install.txt file when the repository contained no demo projects and hence no additional requirements to install.
5 Monate, 1 Woche ago von Luc Saffre Antwort auf Luc Saffre about #269 (test and deploy) : This caused a little commit in quite a few repositories.
5 Monate, 1 Woche ago von Luc Saffre about #269 (test and deploy) (3 Antworten) : I noticed a subtle bug: The Plugin.get_requirements() method of the react plugin was yielding "lino_react". This was nonsense: a plugin shouldn't specify itself as dependency. I noticed this bug because of a failure in amici.
5 Monate, 1 Woche ago von Luc Saffre Antwort auf Luc Saffre about #269 (test and deploy) : I ran "farm show" to verify that all our servers are now on Python 3.11 at least. So I replaced 3.10 by 3.11 in the gitlab-ci file in book.
5 Monate, 1 Woche ago von Luc Saffre about #269 (test and deploy) (1 Antwort) : The test-py313 job now passes on GitLab. The test-py310 still has 14 failures, which are mostly (if not all) caused by silly trivial differences in output, IOW Lino would run perfectly on 3.10, only the doctests are failing. I wonder whether we still want to support Python 3.10...
5 Monate, 1 Woche ago von Luc Saffre about #269 (test and deploy) : The book test suite on GL is currently failing with lots of error messages and I think it's because I separated "prep" and "test" into two different tasks. I don't remember why I did this and now reunited them.
5 Monate, 1 Woche ago von Luc Saffre Antwort auf Luc Saffre about #269 (test and deploy) : I removed that import because I couldn't find where it is being used. And then I accidentally added this change before running the test suite.
5 Monate, 1 Woche ago von Luc Saffre about #269 (test and deploy) (1 Antwort) : from datetime import UTC causes ImportError in Python 3.10 because it was introduced only in 3.11.
5 Monate, 1 Woche ago von Luc Saffre about #269 (test and deploy) : The test_developer_env.sh in getlino was failing on GL because the gitlab-ci.yml calls sudo to simulate user joe, but passes -E, which also sets HOME to /root, and then the user joe says "cd", it causes a permission denied.
5 Monate, 2 Wochen ago von Luc Saffre Antwort auf Luc Saffre about #269 (test and deploy) : And froinde now also runs the latest version.
5 Monate, 2 Wochen ago von Luc Saffre Antwort auf Luc Saffre about #269 (test and deploy) : Jane is back after the upgrade.
5 Monate, 2 Wochen ago von Luc Saffre about #269 (test and deploy) (2 Antworten) : I will now upgrade jane and froinde.
5 Monate, 2 Wochen ago von Luc Saffre about #269 (test and deploy) : @8lurry please have a look at docs/plugins/publisher.rst, it fails because of some Bengali translations.
5 Monate, 2 Wochen ago von Sharif Mehedi about #269 (test and deploy) : I pushed some of my changes in lino, xl, book, presto and react.
5 Monate, 3 Wochen ago von Luc Saffre about #269 (test and deploy) : I made two other quickfixes and releases to python in order to finally get rid of #6774 ('NoneType' object has no attribute 'has_required_roles') which caused 2 disabled system tasks on Jane (checksummaries and send_weekly_report).
5 Monate, 3 Wochen ago von Luc Saffre Antwort auf Luc Saffre about #269 (test and deploy) : Jane is back after the upgrade.
5 Monate, 3 Wochen ago von Luc Saffre about #269 (test and deploy) (1 Antwort) : I will upgrade Jane now.
6 Monate, 2 Wochen ago von Luc Saffre Antwort auf Sharif Mehedi about #269 (test and deploy) : Yes, indeed #6715 (Background color of modified fields is red ?!) is not yet done. The default config should have a reasonable background color.
6 Monate, 2 Wochen ago von Sharif Mehedi about #269 (test and deploy) (1 Antwort) : @luc, FYI, you should probably take care of the red color (the bg_unsaved_modification) before upgrading the production sites, such as prima or any other, set the right color for the themes that they use.
6 Monate, 2 Wochen ago von Sharif Mehedi about #269 (test and deploy) : Here at this place social_django sets the registry.default_strategy which doesn't run in a lino application and raises the exception.
6 Monate, 2 Wochen ago von Luc Saffre Antwort auf Luc Saffre about #269 (test and deploy) : After "pip install -U social-auth-app-django" @8lurry also gets the error.
6 Monate, 2 Wochen ago von Luc Saffre about #269 (test and deploy) : I am upgrading ets, mostly for testing.
6 Monate, 2 Wochen ago von Luc Saffre about #269 (test and deploy) : I released cd to pypi. Had to fix two Sphinx Syntax errors in the README because build was complaining: ERROR `long_description` has syntax errors in markup and would not be rendered on PyPI.
6 Monate, 2 Wochen ago von Luc Saffre about #269 (test and deploy) (1 Antwort) : I don't understand why pm demotest in shop1 is failing on my computer with social_core.exceptions.DefaultStrategyMissingError: Default strategy is not configured
6 Monate, 2 Wochen ago von Luc Saffre about #269 (test and deploy) : I reverted the verbose_name for CONTENT_TYPE_FIELD because it causes doctest failures in welfare. Rather than specifying a verbose_name here, we should modify the model's verbose_name and verbose_name_plural. But first let's find a better name for "Content type".
6 Monate, 3 Wochen ago von Sharif Mehedi Antwort auf Luc Saffre about #269 (test and deploy) : I don't have any such exception in shop1. the pm demotest seem to pass.
6 Monate, 3 Wochen ago von Luc Saffre about #269 (test and deploy) (1 Antwort) : I have a failure "social_core.exceptions.DefaultStrategyMissingError: Default strategy is not configured" when I say pm demotest in shop1. Do you have this too, @8lurry ?
6 Monate, 3 Wochen ago von Luc Saffre about #269 (test and deploy) : I now fixed the failures and pushed my changes in lino, xl, book and others.
6 Monate, 3 Wochen ago von Luc Saffre Antwort auf Sharif Mehedi about #269 (test and deploy) : Yes, indeed. And I forgot to mention it here.
6 Monate, 3 Wochen ago von Sharif Mehedi about #269 (test and deploy) (1 Antwort) : There are some test failures in book, and I cannot source them to my changes. They are probably related to your change, @luc .
6 Monate, 3 Wochen ago von Luc Saffre about #269 (test and deploy) : I upgraded froinde as a dress rehearsal before upgrading the avanti production site. And because that took more time than expected, I wrote a message to avanti that they must wait another day.
7 Monate, 1 Woche ago von Luc Saffre about #269 (test and deploy) : I removed mentori and openui5 from the list of known repositories in synodal, which causes three failures in getlino doctests. I'll fix them now.
7 Monate, 3 Wochen ago von Luc Saffre about #269 (test and deploy) : pm prep in noi1e is failing with "Can't compile non template nodes". This is a bug introduced by my yesterday's changes. It's silly but well hidden, I'm still trying to fix it.
7 Monate, 4 Wochen ago von Luc Saffre about #269 (test and deploy) : I need to release a new version of etgen to pypi in order to fix a test failure in book on GitLab
8 Monate ago von Luc Saffre Antwort auf Luc Saffre about #269 (test and deploy) : Yes, here it is: gitlab.com/lino-framework/book/-/jobs/13193462856
It seems that there is some copy & paste problem with the bn local on my computer. @8lurry let's have a look at this together (unless you have an idea what I can try).
8 Monate ago von Luc Saffre about #269 (test and deploy) (1 Antwort) : My changes will probably introduce the following failure in book:
122 >>> ar.show('publisher.Pages', display_mode="grid", language="en",
Differences (unified diff with -expected +actual):
@@ -15,8 +15,8 @@
12 Datenschutz de Startseite Allgemeine Geschäftsb...
8 Monate, 2 Wochen ago von Sharif Mehedi about #269 (test and deploy) : I updated the docs/specs/cosi5/index.rst
9 Monate ago von Luc Saffre about #269 (test and deploy) : Jane is back after the upgrade.
9 Monate ago von Luc Saffre about #269 (test and deploy) : I will soon upgrade Jane. I already upgraded froinde. Both upgrades are just for general testing.
9 Monate ago von Luc Saffre Antwort auf Luc Saffre about #269 (test and deploy) : This issue was just because www.synodalsoft.net wasn't available (because of my experiments for #6574 (Use zone (protonmail) instead of running own mail servers). Now it is back online and sphinx-build findes the intersphinx inventory: ...
loading intersphinx inventory 'ss' from www.synodalsoft.net/objects.inv ...
...
9 Monate ago von Luc Saffre about #269 (test and deploy) (1 Antwort) : The next failure in algus is a more complex issue: WARNING: term not in glossary: 'demo site' [ERROR Malformed reference '.term' (must be :) in '[ref.term]' at position 183-193]
WARNING: term not in glossary: 'site manager' [ERROR Malformed reference '.term' (must be :) in '[ref.term]' at position 263-273] These glossary terms are defined in the the general Lino documentation, more precisely in the ss repository, and should link to www.synodal...
9 Monate ago von Luc Saffre about #269 (test and deploy) : algus was failing with locale.Error: unsupported locale setting. I added "apt-get install -y tzdata locales-all" to the .gitlab-ci.yml file.
9 Monate, 2 Wochen ago von Luc Saffre Antwort auf Sharif Mehedi about #269 (test and deploy) : That's why you have the difference.
9 Monate, 2 Wochen ago von Sharif Mehedi Antwort auf Luc Saffre about #269 (test and deploy) (1 Antwort) : I have django-5.2.
9 Monate, 2 Wochen ago von Luc Saffre Antwort auf Sharif Mehedi about #269 (test and deploy) (1 Antwort) : I'd guess it depends on the Django version. Do you have version 6+ in your env?
9 Monate, 2 Wochen ago von Sharif Mehedi about #269 (test and deploy) (1 Antwort) : Suddenly for some reason the contenttype id for Ticket Model has changed from 28 to 29 again in noi. I am unable to find a reasonable explanation. Should I just update tests and ignore it?
9 Monate, 3 Wochen ago von Luc Saffre about #269 (test and deploy) : I fixed a series of failures in the book that was there because I still had Django < 6 on my machine. With Django 6 the IDs of some content types are different.
9 Monate, 3 Wochen ago von Luc Saffre about #269 (test and deploy) : Uff! It was because uploads.Upload.as_paragraph() said rv = self.memo2html(ar, '') instead of rv = self.memo2html(ar, None) I probably introduced this during some sprint.
9 Monate, 3 Wochen ago von Luc Saffre Antwort auf Luc Saffre about #269 (test and deploy) : I still have not found the explanation for this!
9 Monate, 4 Wochen ago von Luc Saffre about #269 (test and deploy) (1 Antwort) : doctest docs/specs/avanti/uploads.rst fails in book. It's probably me the culprit.
10 Monate, 1 Woche ago von Luc Saffre about #269 (test and deploy) : I also updated froinde (mostly to test everything before upgrading pdg).
10 Monate, 3 Wochen ago von Luc Saffre Antwort auf Luc Saffre about #269 (test and deploy) : Froinde is back, and I tested it a bit.
10 Monate, 3 Wochen ago von Luc Saffre about #269 (test and deploy) (1 Antwort) : I'll upgrade froinde now, in order to test the latest changes also there.
10 Monate, 3 Wochen ago von Luc Saffre about #269 (test and deploy) : There's a failure in docs/plugins/sources.rst caused by my recent sprint for the songbook Lino.
11 Monate, 2 Wochen ago von Luc Saffre Antwort auf Luc Saffre about #269 (test and deploy) : No, 17 (18) it the number of fields, not the number of rows. So it is probably because GitHub uses the PyPI versions of Lino and XL. I changed the requirements.txt to use the GitHub versions.
11 Monate, 2 Wochen ago von Luc Saffre about #269 (test and deploy) (1 Antwort) : There is currently a strange failure in vedi : On GitLab it the demo data has 17 pages but on my computer it has 18 pages. How is that possible?
1 Jahr ago von Luc Saffre Antwort auf Luc Saffre about #269 (test and deploy) : Fixed
1 Jahr ago von Luc Saffre about #269 (test and deploy) (1 Antwort) : ar.show() in a doctest does'nt yet work when display_mode is tiles.
1 Jahr ago von Luc Saffre about #269 (test and deploy) : There are still test 14 failures in book. I'm working on them. Some caused by #6404 (Inconsistent dataKey in LightWeightContainer values) and some by #6379 (Write a Lino Vedi prototype for Pallas Art School)
1 Jahr ago von Luc Saffre about #269 (test and deploy) : I now published my work of the last days on #6379 (Write a Lino Vedi prototype for Pallas Art School) and #6396 (Schülerliste alphabetisch geordnet) in lino, xl, book and a few other repos.
1 Jahr ago von Luc Saffre about #269 (test and deploy) : Vedi is now failing on GL because it needs the photos from DEMO_DATA, which is part of book.
1 Jahr ago von Luc Saffre about #269 (test and deploy) : I removed lino_cms in synodal and getlino. Lino CMS is no longer maintained. Successors are e.g. Lino Noi (with_cms) and Lino Vedi.
1 Jahr ago von Luc Saffre about #269 (test and deploy) : I pushed a series of minor optimizations in lino, xl, book and react.
1 Jahr ago von Luc Saffre about #269 (test and deploy) : Oops there were some failures in the book that were caused by my recent changes. I now fixed them all (or at least I hope so).
1 Jahr, 1 Monat ago von Luc Saffre about #269 (test and deploy) : I also upgraded froinde.
1 Jahr, 2 Monate ago von Luc Saffre about #269 (test and deploy) : I also upgraded froinde now.
1 Jahr, 3 Monate ago von Luc Saffre about #269 (test and deploy) : In test_developer_env it is failing during pm prep in cosi1 with this traceback:
File "/root/lino/env/repositories/lino/lino/modlib/notify/fixtures/demo2.py", line 33, in objects yield rt.models.notify.Message.create_message( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/root/lino/env/repositor...
1 Jahr, 3 Monate ago von Luc Saffre about #269 (test and deploy) : This failure comes because cosi is not released to PyPI (getlino on a prod server uses the pypi versions). So I will now release cosi to PyPI.
1 Jahr, 3 Monate ago von Luc Saffre about #269 (test and deploy) (1 Antwort) : Now presto runner failed already at installation, saying "ERROR: Some build dependencies for pisa from files.pythonhosted.org/packages/44/6d/c6b29a093cb8d62eb540921ec84f5fd53fa56431805f7ea75fa73db98176/pisa-4.2.tar.gz (from lino-book->lino_presto==25.4.0) conflict with the backend dependencies: setu...
1 Jahr, 3 Monate ago von Luc Saffre about #269 (test and deploy) (2 Antworten) : I saw this failure in presto and maybe that's a quick win. The uploads demo must not rely on whether book is installed or not, we must add some option. I'll lokk into it now.
1 Jahr, 3 Monate ago von Luc Saffre about #269 (test and deploy) : It took me some time to fix a silly doctest failure in docs/plugins/accounting.rst, which seems to be caused by a new version of some Python module that wraps the output of shell('python manage.py reregister --help'). Usually the text width is not important because we set +NORMALIZE_WHITESPACE but t...
1 Jahr, 4 Monate ago von Sharif Mehedi about #269 (test and deploy) (1 Antwort) : inv test on book repository fails with some doctest failure where cases work on cosi1 demo data; an exception comes from dbhash.check_virgin().
1 Jahr, 4 Monate ago von Sharif Mehedi about #269 (test and deploy) (1 Antwort) : I am about to release to pypi. afterwards I will shutdown jane make an upgrade.
1 Jahr, 5 Monate ago von Luc Saffre about #269 (test and deploy) : The doctest failure "56: BE55771021809244 : ['Not a valid IBAN.']" in book/docs/specs/iban.rst comes because a new version of python-stdnum has been released, which I didn't yet have while developing.
1 Jahr, 5 Monate ago von Luc Saffre about #269 (test and deploy) : Ha! book/docs/specs/notify.rst had a code snippet that failed when `pm prep` had been run before 5:48 in the morning or afterwards. To fix this, lino/modlib/notify/fixtures/demo2.py now dates the welcome messages one day before the demo date so that they are always the first messages in the list.
1 Jahr, 6 Monate ago von Luc Saffre about #269 (test and deploy) : I merged the two tickets #881 (Review test suites after a series of changes) and #269 (Get Lino to pass on GitLab CI) into a single ticket #269 (test and deploy).
1 Jahr, 6 Monate ago von Luc Saffre about #269 (test and deploy) : The failure was probably because the 'checkdata' fixture was missing in demo_fixtures. But I don't understand why this failure came out only now.
1 Jahr, 6 Monate ago von Luc Saffre about #269 (test and deploy) : There is a failure in doctest docs/projects/noi2.rst saying lino.modlib.linod.models.SystemTask.DoesNotExist: SystemTask matching query does not exist. I'm trying to understand it.
1 Jahr, 6 Monate ago von Luc Saffre about #269 (test and deploy) : I pushed a series of changes for #5670 (Support Peppol e-invoicing using Ibanity) , #6038 (The first address of a partner should be primary) , #6040 (How to handle channels.exceptions.ChannelFull)
1 Jahr, 6 Monate ago von Luc Saffre about #269 (test and deploy) : It's cumbersome to get a list of the failures across all our projects. Maybe there's a GitLab feature we are missing. Maybe we can use the to-do list?
1 Jahr, 6 Monate ago von Luc Saffre about #269 (test and deploy) : @8lurry let's have a look at GitLab together when we meet again.
1 Jahr, 6 Monate ago von Luc Saffre about #269 (test and deploy) (1 Antwort) : I'm having a failure i've never seen before:
../book/docs/plugins/linod.rst::linod.rst Fatal Python error: Segmentation fault (...) running the test CRASHED with signal 11
1 Jahr, 6 Monate ago von Luc Saffre about #269 (test and deploy) : I added a startup.py script to avanti1 because it seems that some doctest is causing a database change without tidying up. It adds a countries.Place so that the database contains 81 instead of 80 rows.
1 Jahr, 6 Monate ago von Luc Saffre about #269 (test and deploy) : In sphinxfeed-lsaffre, "inv test" didn't run any tests.
1 Jahr, 7 Monate ago von Luc Saffre about #269 (test and deploy) : Yes this failure was caused by my own change: i changed display_mode of courses.EnrolmentsByCourse from html to grid.
1 Jahr, 7 Monate ago von Luc Saffre about #269 (test and deploy) (2 Antworten) : @8lurry do you also have the following doctest failure in welfare?

388 >>> print(analyzer.show_window_fields()) #doctest: +ELLIPSIS +NORMALIZE_WHITESPACE +REPORT_UDIFF Differences (unified diff with -expected +actual): @@ -54,7 +54,7 @@ - cal.Tasks.insert : summary, user, project - cal.Tasks...
1 Jahr, 7 Monate ago von Luc Saffre about #269 (test and deploy) : I optimized check_virgin() because I noticed that the tidy_up() in book/docs/plugins/ibanity/documents.rst didn't tidy up well, it forgot to delete the excerpts.
1 Jahr, 7 Monate ago von Luc Saffre about #269 (test and deploy) : After pushing my changes, I manually restarted pull_demos.sh on LF because this morning it failed with a SyntaxError (caused by autopep8, which is activated in pulsar-ide-python)
1 Jahr, 8 Monate ago von Luc Saffre about #269 (test and deploy) : I suggest to merge ticket 881 ("Review test suites") into ticket 269 ("Get Lino to pass on GitLab"). We can ignore the difference... I just mixed them up: wrote my comment in #881 although I meant #269...
1 Jahr, 8 Monate ago von Luc Saffre about #269 (test and deploy) (4 Antworten) : The [url gitlab.com/lino-framework/welfare/-/jobs/9219513475 next failure in welfare] is the same as what I have on my machine; are you sure @8lurry that these are not caused by your changes?
1 Jahr, 8 Monate ago von Luc Saffre about #269 (test and deploy) (2 Antworten) : The [url gitlab.com/lino-framework/welfare/-/jobs/9201366600 current failure in welfare] is probably because lino_book is not installed. I see this because the failure says that there is 1 uploads.Volume and 2 uploads.Uploads less than expected.
1 Jahr, 8 Monate ago von Luc Saffre about #269 (test and deploy) : There is a failure in min9/tests/test_birth_date.py that seems to come from your changes.
1 Jahr, 8 Monate ago von Sharif Mehedi about #269 (test and deploy) : I've git push(ed) some changes on lino, xl, amici, react & book. please pull them
1 Jahr, 8 Monate ago von Luc Saffre about #269 (test and deploy) (2 Antworten) : The next error on GL is about how Python represents an OrderedDict. I thought that this was simply a change caused by our upgrading from Python 3.10 to 3.12, but am surprised to see the "old" representation on GL. I think that the pipeline on GL now runs under Python 3.12. So I don't understand why ...
1 Jahr, 8 Monate ago von Luc Saffre about #269 (test and deploy) (1 Antwort) : The book currently fails with "docs/dev/lets/step4.rst - ValueError: line 130 of the docstring for step4.rst has inconsistent leading whitespace", but theoretically this should not come any more. Background: after discovering that we can call pytest.skip() in order to skip a whole rst file, I had re...
1 Jahr, 8 Monate ago von Luc Saffre about #269 (test and deploy) : Uff, I repaired the test suites after my changes. ow there is still a failure in book, which is for you @8lurry : it says "ERROR: Could not build wheels for pykcs11, which is required to install pyproject.toml-based projects"
1 Jahr, 8 Monate ago von Luc Saffre about #269 (test and deploy) : I have the ball right now because the suite broke from my wip for ibanity.
1 Jahr, 8 Monate ago von Luc Saffre about #269 (test and deploy) : I found a way to omit the silly --ignore=docs/plugins/ibanity.rst options in the pytest.ini file. The documents to skip now call pytest.skip().
1 Jahr, 8 Monate ago von Sharif Mehedi about #269 (test and deploy) (1 Antwort) : Current test failures in book comes from different locale settings.
1 Jahr, 8 Monate ago von Luc Saffre about #269 (test and deploy) : Since we didn't talk about it, let's just try it ;-) That's why I assigned this ticket to you and changed priority to 39. If you have a "blocking" question for this ticket, then write a short comment about your question and assign the ticket to me and set state to "talk".
1 Jahr, 8 Monate ago von Luc Saffre about #269 (test and deploy) (1 Antwort) : @8lurry here is what I forgot to talk about this morning: would you agree to be the poor guy who cares when the test suite on some repository fails? I don't know how this is called in bigger teams, maybe the "Responsible for CI" or "CI coordinator"? In our situation I'd translate it to the following: befo...
1 Jahr, 9 Monate ago von Luc Saffre about #269 (test and deploy) : [url gitlab.com/lino-framework/getlino/-/jobs/8882666958 getlino test_production_server_mysql_nginx] was failing with TypeError: '>=' not supported between instances of 'ImportError' and 'int' because it uses lino_cosi from pypi, which tried to "from lino.modlib.system.choicelists import DashboardLa...
1 Jahr, 9 Monate ago von Luc Saffre about #269 (test and deploy) (1 Antwort) : [url gitlab.com/synodalsoft/prima/-/jobs/8881147752] fails to install book using setup.py, so I convert it to pyproject.toml
1 Jahr, 9 Monate ago von Luc Saffre about #269 (test and deploy) : @8lurry don't forget to adapt the doctests in book. There are several failures because of the new item overridden_column_headers.
1 Jahr, 9 Monate ago von Luc Saffre about #269 (test and deploy) : I will make now a quick release of lino-react in order to test it on the field in jane and froinde.
1 Jahr, 9 Monate ago von Luc Saffre about #269 (test and deploy) : I wonder why the docs (pages) for Lino Prima don't show on [synodalsoft.gitlab.io/prima]. Lino Prima differs from e.g. avanti in that it it on GL in the synodalsoft group, not lino-framework.
1 Jahr, 10 Monate ago von Luc Saffre about #269 (test and deploy) (1 Antwort) : Next error for [url gitlab.com/lino-framework/getlino/-/jobs/8704377401 test_production_server_mysql_nginx in getlino]: ERROR 1396 (HY000) at line 1: Operation CREATE USER failed for 'lino'@'172.17.0.2'
1 Jahr, 10 Monate ago von Luc Saffre about #269 (test and deploy) (1 Antwort) : getlino on GitLab is still saying "service mysqld restart ended with return code 1". But now maybe I fixed it! (we will see soon)
2 Jahre, 1 Monat ago von Luc Saffre about #269 (test and deploy) : I did an upgrade on Jane and Froinde because there was a series of little bugs (text editor, ObjectDoesNotExist, ...)
2 Jahre, 1 Monat ago von Luc Saffre about #269 (test and deploy) : I published my work of the last week (with ca 3 ticket: (inbox plugin, uploads and notify, bugfix courses.StatusReport)
2 Jahre, 3 Monate ago von Luc Saffre about #269 (test and deploy) : bash doesn't expand alias statements in non-interactive mode. To turn this on you need to run the command shopt -s expand_aliases before the rest of your script (thanks to [url gitlab.com/gitlab-org/gitlab-foss/-/issues/49482])
2 Jahre, 5 Monate ago von Luc Saffre about #269 (test and deploy) : I removed the test_startsite jobs in cosi. tera, voga and welcht because they seem to be the remainder of some unfinished exercise that never worked. But I added a simplified test_startsite in amici.
2 Jahre, 5 Monate ago von Luc Saffre about #269 (test and deploy) : GitLab [url gitlab.com/lino-framework/book/-/jobs/6828785567 shows us] that I need to upgrade my babel package. Seems that there is no comma after the weekday when you say "Saturday 11 May".
2 Jahre, 7 Monate ago von Luc Saffre about #269 (test and deploy) : docs/specs/getlino/startsite.rst fails with "ModuleNotFoundError: No module named 'lino_amici'" on [url gitlab.com/lino-framework/book/-/jobs/6423611916 gitlab],
2 Jahre, 8 Monate ago von Luc Saffre about #269 (test and deploy) : @8lurry please have a look at docs/specs/cosi5/index.rst, it needs to get adapted after my recent changes.
2 Jahre, 10 Monate ago von Luc Saffre about #269 (test and deploy) : I pushed my work on at least three different tickets: #5278 (Jane doesn't send mails) #5334 (Better default implementation of TableRow.as_paragraph()) #5296 (Issues on LF when pm prep moves media to /tmp/media.bak)
3 Jahre ago von Luc Saffre about #269 (test and deploy) : The test failure in docs/plugins/search.rst (Field 'id' expected a number but got <lino.core.auth.utils.AnonymousUser object) was caused because Lino tried to also search anonymously in google.SyncSummary. I "fixed" this by setting SyncSummary.show_in_site_search to False.
3 Jahre, 1 Monat ago von Luc Saffre about #269 (test and deploy) (1 Antwort) : NB: instead of saying `["" for _ in range(6)]` you can say `[""] * 6`
3 Jahre, 1 Monat ago von Luc Saffre about #269 (test and deploy) (2 Antworten) : doctest docs/dev/polls/index.rst is failing with "FileNotFoundError: [Errno 2] No such file or directory: '/home/luc/work/book/lino_book/projects/polls/polls/migrations', and I don't understand why the Command.makemigrations() method exists.
3 Jahre, 2 Monate ago von Sharif Mehedi about #269 (test and deploy) (1 Antwort) : @luc , how do you stop the logs "Started ..." and "Done ..." from coming when running the test suite.
3 Jahre, 2 Monate ago von Luc Saffre Antwort auf Luc Saffre about #269 (test and deploy) : One thing is clear: I'd rather not delete the uploads folder *accidentally* on some production site. When testing a preview site, we use rsync to keep the uploads directory synced.
3 Jahre, 2 Monate ago von Luc Saffre Antwort auf Luc Saffre about #269 (test and deploy) : Ha! It's because these orphaned upload files are there from previous "pm prep" runs on my machine! That's the explanation. How to avoid this situation also in the other demo databases? Maybe "pm prep" should start by removing cache files.
3 Jahre, 2 Monate ago von Luc Saffre about #269 (test and deploy) (3 Antworten) : docs/specs/jinja.rst is intriguing. Looks as if the help plugin has gotton a config directory on GitLab. Strange.
3 Jahre, 2 Monate ago von Luc Saffre about #269 (test and deploy) : It is advancing. Installation now works and the test suite runs. And it has only a few failures. The last one is for SHarif. The first one says that in cms1 there are now (on GL) 8 instead of 6 checkdata errors. Hm. Now I'd like to see these messages...
3 Jahre, 2 Monate ago von Luc Saffre about #269 (test and deploy) : Okay I see, I had tests_require=['pytest', 'pytest-html', 'pytest-forked', 'pytest-xdist'] in the book's setup_info.py, but that keyword to setup is deprecated and no longer used. I was inspired by [url stackoverflow.com/questions/4734292/specify-where-to-install-tests-require-dependencies-of-a-dist...
3 Jahre, 2 Monate ago von Sharif Mehedi about #269 (test and deploy) : okay. I'll look after them.
3 Jahre, 2 Monate ago von Luc Saffre about #269 (test and deploy) : There are two failures now in the book test suite, and I think that they are for you, @8lurry
3 Jahre, 2 Monate ago von Luc Saffre about #269 (test and deploy) : GitLab says for the test job on book: This job is stuck because of one of the following problems. There are no active runners online, no runners for the protected branch , or no runners that match all of the job's tags: bombur.
3 Jahre, 2 Monate ago von Luc Saffre about #269 (test and deploy) : The doctest docs/projects/roger.rst continues to fail when run by inv test (i.e. together with all other test cases) and it succeeds when run alone. Mysterioous.
3 Jahre, 2 Monate ago von Luc Saffre about #269 (test and deploy) : The book test suite still has 8 failures on my machine.
3 Jahre, 3 Monate ago von Luc Saffre Antwort auf Sharif Mehedi about #269 (test and deploy) : I cannot reproduce this on my machine.
3 Jahre, 3 Monate ago von Luc Saffre about #269 (test and deploy) : I committed a series of changes in lino because they seem quite safe and because I guess that they don't change the test suites (and because I wanted to clean them away from my local long-lasting work on the storage plugin...)
3 Jahre, 3 Monate ago von Sharif Mehedi about #269 (test and deploy) : Also, checkdata seems to put a lot of extra messages then before, I leave it up to @luc for now.
3 Jahre, 3 Monate ago von Sharif Mehedi about #269 (test and deploy) (1 Antwort) : noi1e/tests/test_system_tasks.py is failing. I think the test case is fine and the failure is coming from checkdata (schedule_daily) it says: User.DoesNotExist for username "robin". Something changed in checkdata and I am not sure what yet.
3 Jahre, 3 Monate ago von Luc Saffre about #269 (test and deploy) : My mistake, I added it and committed without running the test suite. I suggest to deactivate the line.
3 Jahre, 3 Monate ago von Sharif Mehedi about #269 (test and deploy) : This [url gitlab.com/lino-framework/lino/-/commit/c22532527380b56be93a37920d23b717c7591879#e43edfba6b98ff9907092c3fed7a242f9f1ac73b_105_104 log message] is showing up on a lot of test cases. And making them fail, like so:
======================================== FAIL: atelier.test.DocTestCase (docs/...
3 Jahre, 4 Monate ago von Luc Saffre about #269 (test and deploy) : getlino CI is [url gitlab.com/lino-framework/getlino/-/jobs/4386952834 failing] with django.core.exceptions.ValidationError: {'iban': ['Not a valid IBAN.']} during "pm prep" of cosi1.
3 Jahre, 7 Monate ago von Luc Saffre about #269 (test and deploy) : I am adapting the welfare doctests.
3 Jahre, 7 Monate ago von Luc Saffre about #269 (test and deploy) : The Calendar.modified field is now added only when google plugin is installed.
3 Jahre, 7 Monate ago von Luc Saffre about #269 (test and deploy) : docs/specs/jinja.rst was failing because vat plugin no longer has a config dir, but on my machine the empty directory still existed.
3 Jahre, 7 Monate ago von Luc Saffre about #269 (test and deploy) : docs/plugins/help.rst fails with "AttributeError: '_Helper' object has no attribute 'SiteContacts'" for a line that says "rt.show(help.SiteContacts)". Explanation : lino_cms now has the help plugin installed, but GL is still using the old version.
3 Jahre, 7 Monate ago von Luc Saffre about #269 (test and deploy) : The failure in docs/apps/cms/db.rst ([url gitlab.com/lino-framework/book/-/jobs/3961711150#L5812 url]) is because I had some local changes in cms. I committet them now, but I did not yet hit the retry button in book.
3 Jahre, 7 Monate ago von Luc Saffre about #269 (test and deploy) : I manually tried in the polly project and then adapted book/docs/specs/polls.rst : the call to polls.Responses.toggle_choice() does not need mk and mk in base_params.
3 Jahre, 7 Monate ago von Luc Saffre about #269 (test and deploy) : The failure in docs/specs/noi/general.rst can wait until #4898 is done.
3 Jahre, 7 Monate ago von Luc Saffre Antwort auf Luc Saffre about #269 (test and deploy) : Same for docs/specs/polls.rst
3 Jahre, 7 Monate ago von Luc Saffre about #269 (test and deploy) (1 Antwort) : For the failure in docs/specs/households.rst I want to talk with @8lurry : the base_params have changed. I guess this is correct, but I would like to verify.
3 Jahre, 7 Monate ago von Luc Saffre Antwort auf Luc Saffre about #269 (test and deploy) : The same in doctest docs/specs/holidays.rst and min9.
3 Jahre, 7 Monate ago von Luc Saffre about #269 (test and deploy) (1 Antwort) : In docs/specs/export_excel.rst somebody (I guess it was me) had blindly accepted the calendar entry states tentativ, etc injected by the google plugin although this page uses the min3 demo project, which does not use the google plugin.
3 Jahre, 7 Monate ago von Luc Saffre about #269 (test and deploy) : I fixed a few book test failures and pushed my changes.
3 Jahre, 7 Monate ago von Luc Saffre about #269 (test and deploy) : I sayd "git mv lino/config/makedocs lino/modlib/help/config/makehelp" and changed the makehelp command accordingly.
3 Jahre, 9 Monate ago von Sharif Mehedi about #269 (test and deploy) : book test suite fails. for which I am to blame. I will work on it tomorrow.
3 Jahre, 9 Monate ago von Sharif Mehedi about #269 (test and deploy) : fixed two test cases related to extended manage.py/execute_from_command_line and another one related to Bengali translation from cosi5
3 Jahre, 9 Monate ago von Luc Saffre about #269 (test and deploy) (1 Antwort) : I fixed the failures caused by linod now knowing that it requires daphne. I left one failure open because I don't understand its reason: docs/apps/cms/db.rst shows that there are now 25 rows instead of 23 in albums.Album.
3 Jahre, 9 Monate ago von Luc Saffre about #269 (test and deploy) : @8lurry, I will now work on the book test suite and adapt it to your changes as well. Luc stealing other people's work again.
3 Jahre, 9 Monate ago von Luc Saffre Antwort auf Luc Saffre about #269 (test and deploy) : Oops, I see that at least one of the failures was because i didn't pull your work in cms.
3 Jahre, 9 Monate ago von Luc Saffre about #269 (test and deploy) (1 Antwort) : Sharif, please have a look at the book test suite. It shows your recent changes :-) You are responsible for adapting the book after your changes :-)
3 Jahre, 10 Monate ago von Luc Saffre about #269 (test and deploy) : I released atelier to PyPI because this should fix the failure "AttributeError: 'NoneType' object has no attribute 'split'" in the react repo.
4 Jahre ago von Sharif Mehedi about #269 (test and deploy) : I cannot figure why rt.show is showing detail instead of table.
4 Jahre ago von Luc Saffre Antwort auf Sharif Mehedi about #269 (test and deploy) : I had forgotten to push cms, Sharif had forgotten to pull xl.
4 Jahre ago von Sharif Mehedi about #269 (test and deploy) (1 Antwort) : There are some issues remaining in new Publisher implementation. @luc and I should review it together.
4 Jahre ago von Sharif Mehedi about #269 (test and deploy) : this one data point check should be done from a test case, if we decide to do it.
4 Jahre ago von Sharif Mehedi about #269 (test and deploy) : For vat demo data, we can just NOT check online. It's a waste for us and as well as for the people who are serving the data. We should probably have only one data point to check online, so that lino knows that the vat data check api is working right, and NOT do the check for every other data point.
4 Jahre ago von Sharif Mehedi about #269 (test and deploy) : To run the test suite I set vat.use_online_check to False in pierre settings. Should we keep it set to False?
4 Jahre, 2 Monate ago von Sharif Mehedi Antwort auf Sharif Mehedi about #269 (test and deploy) : Yes, I am trying to work it out, linod is not just a command anymore since it became a plugin.
4 Jahre, 2 Monate ago von Luc Saffre about #269 (test and deploy) : We get "AttributeError: 'NoneType' object has no attribute 'build_site_cache'" during [url gitlab.com/lino-framework/book/-/jobs/2893039105 inv prep in book on GitLab], but I can't reproduce it locally. I guess that Sharif and I must have a look at this together.
4 Jahre, 2 Monate ago von Luc Saffre Antwort auf Sharif Mehedi about #269 (test and deploy) : Is this still relevant?
4 Jahre, 2 Monate ago von Luc Saffre Antwort auf Luc Saffre about #269 (test and deploy) : Took more time, but works also.
4 Jahre, 2 Monate ago von Luc Saffre about #269 (test and deploy) (1 Antwort) : Oops, I used the GitLab Import function instead of [url dev.lino-framework.org/team/gh2gl.html#how-to-move-a-repo-from-github-to-gitlab my checklist] for moving a repos from GH to GL.
4 Jahre, 2 Monate ago von Luc Saffre about #269 (test and deploy) : Oh, I see that rstgen is still being hosted on GitLab.
4 Jahre, 2 Monate ago von Sharif Mehedi about #269 (test and deploy) (2 Antworten) : we need to do some major changes in the dev/linod.rst (maybe we should move it to /specs/) and specs/notify.rst, I am having a look at them right now and try to figure things out if I can.
4 Jahre, 2 Monate ago von Luc Saffre about #269 (test and deploy) : The function returned by a decorator must return the func object it has been given as argument.
4 Jahre, 2 Monate ago von Sharif Mehedi about #269 (test and deploy) : avanti.fixtures.demo2 is failing saying, NoneType object is not callable. Something related to course. I don't know what caused the problem.
4 Jahre, 4 Monate ago von hannes about #269 (test and deploy) : The workaround hinted by Luc helped and now inv bd completes successfully. However, pp -l gives: File "/home/user/lino/env/lib/python3.9/site-packages/pkg_resources/__init__.py", line 800, in resolve raise VersionConflict(dist, req).with_context(dependent_req) pkg_resources.ContextualVersionConflic...
4 Jahre, 4 Monate ago von Luc Saffre Antwort auf hannes about #269 (test and deploy) : Ha! I know the reason!rstgen does not yet include the templates when installed using pypu. Workaround: Try installing from a clone of the rstgen repo.
4 Jahre, 4 Monate ago von hannes about #269 (test and deploy) (1 Antwort) : After pulling necessary repos, after inv bd in book got following traceback: Traceback (most recent call last): File "/home/user/lino/env/lib/python3.9/site-packages/sphinx/cmd/build.py", line 276, in build_main app.build(args.force_all, filenames) File "/home/user/lino/env/lib/python3.9/site-pac...
4 Jahre, 4 Monate ago von Luc Saffre about #269 (test and deploy) : You must also pull lino (and all other repos to be sure).
4 Jahre, 4 Monate ago von hannes about #269 (test and deploy) : Got the folowing: go book git pull pip install -U rstgen inv bd Now I got traceback: Traceback (most recent call last): File "/home/user/lino/env/lib/python3.9/site-packages/sphinx/config.py", line 332, in eval_config_file exec(code, namespace) File "/home/user/lino/env/repositories/book/docs/con...
4 Jahre, 4 Monate ago von Sharif Mehedi Antwort auf hannes about #269 (test and deploy) : Other then sphinx_design everything was fine. but we have an updated version of rstgen on pypi. Try the command "pip install -U rstgen", which will install the latest version.
4 Jahre, 4 Monate ago von Sharif Mehedi Antwort auf hannes about #269 (test and deploy) : I got a different issue, saying, `sphinx_design` not found. I can do pip install sphinx_design, but we should probably add it to requirements.txt
4 Jahre, 4 Monate ago von hannes about #269 (test and deploy) (2 Antworten) : I got some issues concerning lino book: go book git pull inv bd ..... ModuleNotFoundError: No module named 'rstgen.sphinxconf'
However: pip install rstgen Requirement already satisfied: rstgen in /home/user/lino/env/repositories/rstgen (21.5.0)
4 Jahre, 4 Monate ago von Sharif Mehedi about #269 (test and deploy) : `pm prep` on pronto says: Failed to save Journal, reason: voucher_type is null, coming from pronto/fixtures/minimal_ledger
4 Jahre, 4 Monate ago von Sharif Mehedi about #269 (test and deploy) : in book: dt docs/topics/datetime.rst gives: /home/blurry/lino/env/lib/python3.8/site-packages/dateparser/date_parser.py:35: PytzUsageWarning: The localize method is no longer necessary, as this time zone supports the fold attribute (PEP 495). For more details on migrating to a PEP 495-compliant imple...
4 Jahre, 5 Monate ago von Luc Saffre about #269 (test and deploy) : Ouch: makehelp also does from atelier import sphinxconf. Yes, so we would have to move the whole sphinxconf functionality out of atelier. And yes, why not to rstgen. That means quite some code changes. But it makes sense. To be meditated.
4 Jahre, 5 Monate ago von Luc Saffre about #269 (test and deploy) : I think we want to avoid installing atelier on a production site. I moved a few utility functions from atelier to rstgen to fix yet another dependency.
4 Jahre, 5 Monate ago von Sharif Mehedi Antwort auf Luc Saffre about #269 (test and deploy) : It's gone now.
4 Jahre, 5 Monate ago von Luc Saffre Antwort auf Luc Saffre about #269 (test and deploy) (1 Antwort) : Yes, I think that it should go away from get_requirements.
4 Jahre, 5 Monate ago von Sharif Mehedi Antwort auf Luc Saffre about #269 (test and deploy) : I added 'atelier' to help.Plugin.get_requirements. If help plugin really NOT need atelier then `atelier` can go away from get_requirements of the help plugin.
4 Jahre, 5 Monate ago von Luc Saffre Antwort auf Luc Saffre about #269 (test and deploy) (2 Antworten) : No, it seems that the solution is simple: makehelp does actually not need atelier. It tried to import it but never used it. The bug was in lino, where it is now fixed. But I guess that we need to release Lino to PyPI before seeing the effect in the getlino tests. So let's say that getlino test suite...
4 Jahre, 5 Monate ago von Luc Saffre about #269 (test and deploy) (1 Antwort) : In getlino we have a failure [url gitlab.com/lino-framework/getlino/-/jobs/2334021381 "ModuleNotFoundError: No module named 'atelier'"]. Yes, indeed: atelier is normally not needed on a production server. But makehelp needs it. Not yet sure how to fix this.
4 Jahre, 5 Monate ago von Luc Saffre about #269 (test and deploy) : [url gitlab.com/lino-framework/welfare/-/jobs/2390032553 This failure] was caused by changed ordering of plugins. Fixed.
4 Jahre, 6 Monate ago von Luc Saffre about #269 (test and deploy) : Sharif and I had a session where we concluded that it was a bad idea to change this dependency. So I reverted it. And we found a better solution in welfare itself (welfare has a customized system plugin, and this must simply be declared in get_installed_apps before super()).
4 Jahre, 6 Monate ago von Luc Saffre about #269 (test and deploy) : But [url gitlab.com/lino-framework/book/-/jobs/2363850311#L5345 this failure] maybe indicate that it was a bad idea to remove 'lino.modlib.system' from gfks. Let's look at it together.
4 Jahre, 6 Monate ago von Luc Saffre Antwort auf Sharif Mehedi about #269 (test and deploy) : Let's talk about it. To me it looks very good.
4 Jahre, 6 Monate ago von Sharif Mehedi about #269 (test and deploy) (1 Antwort) : removing 'lino.modlib.system' from gfks.Plugin.needed_plugins causes some failure in the test suite and some failures does NOT look good. For example in lino_book/docs/dev/actors.rst#L103:
File "docs/dev/actors.rst", line 103, in actors.rst Failed example: kernel.master_tables[0] Expected: lin...
4 Jahre, 6 Monate ago von Sharif Mehedi Antwort auf Sharif Mehedi about #269 (test and deploy) : This is probably out of my league. I created an [url github.com/scrapinghub/dateparser/issues/1052 issue] on dateparser, for the moment we should probably keep it at that.
4 Jahre, 6 Monate ago von Sharif Mehedi about #269 (test and deploy) : [url github.com/mrabarnett/mrab-regex regex], It's a so small package, yet they don't keep a changelog!
4 Jahre, 6 Monate ago von Sharif Mehedi about #269 (test and deploy) (1 Antwort) : Run the test suite, and getting a lot of weird Exceptions generated by regex package. A few days back I upgraded my pip packages. old regex package was 2021.8.28 and the new regex is 2022.3.15. reverting back to the old version fixes the issues but I think I should work on upgrading.
4 Jahre, 8 Monate ago von Luc Saffre about #269 (test and deploy) : Yes, the "could be replaced by an extlink" are now easy to fix for me.
4 Jahre, 8 Monate ago von Sharif Mehedi about #269 (test and deploy) : welfare pages on gitlab are failing, something @luc is better suited to look after.
4 Jahre, 8 Monate ago von Luc Saffre about #269 (test and deploy) : I had several failures in the book regarding changes in calview. I didn't touch these. @8lurry please have a look at them.
4 Jahre, 9 Monate ago von Sharif Mehedi about #269 (test and deploy) : `inv bd` is failing on gitlab. I think @luc is better suited to look after this.
4 Jahre, 9 Monate ago von Luc Saffre about #269 (test and deploy) : Django 3 came because Django 4 requires Python 3.8, and this is buster, which has Python 3.7 by default.
4 Jahre, 10 Monate ago von Luc Saffre Antwort auf Sharif Mehedi about #269 (test and deploy) : That's not normal, it should install Django 4, shouldn't it? Maybe we specify somewhere "Django<4"? But at first glance I couldn't find any place where we do this.
4 Jahre, 10 Monate ago von Sharif Mehedi about #269 (test and deploy) (1 Antwort) : book is installing django-3.2 on gitlab. should we specify the version number specifically?
4 Jahre, 10 Monate ago von Luc Saffre Antwort auf Sharif Mehedi about #269 (test and deploy) : I released etgen and added you as a maintainer.
4 Jahre, 10 Monate ago von Sharif Mehedi about #269 (test and deploy) (1 Antwort) : to have the test suite passing we need to release etgen to pypi and I don't have access to etgen in pypi.
4 Jahre, 10 Monate ago von Luc Saffre Antwort auf Sharif Mehedi about #269 (test and deploy) : Sounds dangerous. Let's have a look at this together.
4 Jahre, 10 Monate ago von Luc Saffre Antwort auf Sharif Mehedi about #269 (test and deploy) : Actually the ticket existed already: #2723
4 Jahre, 10 Monate ago von Luc Saffre Antwort auf Sharif Mehedi about #269 (test and deploy) : How to make things more elegant? My first guess is to remove the Site class in lino_welfare altogether and to move this code to the Site in lino_weleup. This chaotic situation comes because in the beginning we had one common Site class for all Lino Welfare applications. At some point in history I de...
4 Jahre, 10 Monate ago von Luc Saffre Antwort auf Sharif Mehedi about #269 (test and deploy) : The bug has indeed no influence because lino_welcht does not inherit from the Site in lino_welfare settings, and lino_weleup has a get_apps_modifiers() which overrides both cv and courses.
4 Jahre, 10 Monate ago von Luc Saffre Antwort auf Sharif Mehedi about #269 (test and deploy) : I guess that they should have been replaced by lino_welcht.lib.cv and lino_welcht.lib.courses.
4 Jahre, 10 Monate ago von Sharif Mehedi about #269 (test and deploy) (1 Antwort) : docs/dev/ovfields/index.rst needs a review. Reason: django-4 overrides virtual_fields inherited from base_class.
4 Jahre, 10 Monate ago von Sharif Mehedi about #269 (test and deploy) : features removed from django-4.0:
django.utils.translation.ugettext (and ugettext_lazy) has been removed and replaced them with gettext (and gettext_lazy). django.utils.http.urlquote has been removed and replaced them with urllib.parse.quote. pytz has been removed from django.utils.timezone and depe...
4 Jahre, 10 Monate ago von Sharif Mehedi about #269 (test and deploy) : The test suite is finish and there were no failure related to these welfare app.
4 Jahre, 10 Monate ago von Sharif Mehedi about #269 (test and deploy) : it will probably be wiser to remove these two apps, since they did not existed and welfare was not complaining. but this is something that I should leave up to @luc .
4 Jahre, 10 Monate ago von Sharif Mehedi about #269 (test and deploy) (4 Antworten) : in lino_welfare.modlib.welfare.settings.Site.get_installed_apps() there were two apps that does not exist. 1) 'lino_welfare.chatelet.lib.cv' 2) 'lino_welfare.chatelet.lib.courses'. They probably existed before but not anymore. I replaced the first one with `lino_welfare.modlib.cv` and the later with...
4 Jahre, 11 Monate ago von Sharif Mehedi about #269 (test and deploy) : `inv bd` is failing on gitlab.
4 Jahre, 11 Monate ago von Sharif Mehedi about #269 (test and deploy) : There are some test failures in bool/docs/dev/redirected.rst: seem to be related to lino-framework.org and saffre-rumma.net. (Probably due to poor internet connection.)
5 Jahre ago von Sharif Mehedi about #269 (test and deploy) : Continuation of the previous comment: The following links are not reachable: [url gitlab.com/lino-framework/book/-/blob/master/docs/dev/redirected.rst#L27 on line 27] and [url gitlab.com/lino-framework/book/-/blob/master/docs/dev/redirected.rst#L29 on line 29] of book/docs/dev/redirected.rst file
5 Jahre ago von Sharif Mehedi about #269 (test and deploy) : I had to comment out some test cases in book/docs/dev/redirected.rst because the given URLs there are not valid anymore. I will give more details later.
5 Jahre, 2 Monate ago von Luc Saffre about #269 (test and deploy) : The docs/specs/avanti/uploads.rst fails because the error page no longer sends "charset=utf-8"" header. I guess that this is a side effect of having removed our custom error pages.
5 Jahre, 2 Monate ago von Sharif Mehedi about #269 (test and deploy) : presto should pass again after a lino_xl release to pypi
5 Jahre, 2 Monate ago von Sharif Mehedi about #269 (test and deploy) : amici is still failing on Gitlab. and to fix that we need to do a react release. but I do not want to do a release until i have the browserHistory.push fixed (OTOH, i probably won't be able to do anything about it, and thinking of reporting an issue to it's maintainer)
5 Jahre, 2 Monate ago von Sharif Mehedi about #269 (test and deploy) : I did another release of lino to pypi.
5 Jahre, 2 Monate ago von Luc Saffre about #269 (test and deploy) : And the [url gitlab.com/lino-framework/welfare/-/jobs/1469321291 failure in welfare] is also caused by weasyprint, so release lino to pypi should fix it. NB I recommend to always release xl and lino together (except when it's clear that there was no change in the other one since the last release).
5 Jahre, 2 Monate ago von Luc Saffre about #269 (test and deploy) : Yes, here: [url luc.lino-framework.org/blog/2021/0802.html]. And accordingly the problem might disappear when we release lino to pypi (so that also the amici test sees the dependency and install version 53 of weasyprint).
5 Jahre, 2 Monate ago von Luc Saffre about #269 (test and deploy) : What is wrong with amici on Gitlab? Indeed it says "AttributeError: '_SpoofOut' object has no attribute 'buffer'", called from pydyf (never heard before), called from weasyprint. Dring, there was another problem with weasyprint recently...
5 Jahre, 2 Monate ago von Luc Saffre about #269 (test and deploy) : I discovered and started to use the [url gitlab.com/-/operations Operations Dashboard] on GitLab.
Yes, for book (gitlab.com/lino-framework/book/-/jobs/1479621149) we must release rstgen to pypi. Aha, rstgen is still on GitHUB. I now did the release. I added @8lurry as a second owner.
5 Jahre, 2 Monate ago von Luc Saffre about #269 (test and deploy) : Sharif fixed the belref failures, but then got stuck. He wrote: book is still failing and to solve it i think we need to do a release on pypi for rstgen.
5 Jahre, 3 Monate ago von Luc Saffre about #269 (test and deploy) : Yes, I eliminated a pseudo-feature of atelier.sphinxconf.interproject.configure() : calling it without specifying a list of projects to include was adding all local atelier projects. I created this feature for generating my blog. But I'll remove the feature and add explicit intersphinx dependencies...
5 Jahre, 3 Monate ago von Luc Saffre about #269 (test and deploy) : The book (finally) is green again. Yes, of course I had to add getlino to "interproject.configure()" in the conf.py. The issue is rather: why didn't it fail on my machine?
5 Jahre, 3 Monate ago von Luc Saffre about #269 (test and deploy) : [url gitlab.com/lino-framework/book/-/jobs/1428117401 This build-docs failure on GL] shows that Sphinx did not find the intersphinx index of the getlino doctree. The book rendered on my machine finds it: [url dev.lino-framework.org/tutorials/part_01.html#start-project]. Trying to understand why.
5 Jahre, 3 Monate ago von Luc Saffre about #269 (test and deploy) : and also noi amic cosi react. And then I upgraded froinde.
5 Jahre, 3 Monate ago von Luc Saffre about #269 (test and deploy) : I released to PyPI : getlino lino xl
5 Jahre, 3 Monate ago von Luc Saffre about #269 (test and deploy) : I upgraded froinde and did manual tests.Everything seems to work fine.
5 Jahre, 3 Monate ago von Luc Saffre about #269 (test and deploy) : Jane is back. But the CommentsByRFC panel on a ticket is empty. So to write a comment you need to open that panel in its own window an use the + button in the toolbar.
5 Jahre, 3 Monate ago von Luc Saffre about #269 (test and deploy) : Jane will now go down for an upgrade.
5 Jahre, 4 Monate ago von Luc Saffre about #269 (test and deploy) : Ah, I see: the noi1e/tests/test_notify.py fails because it is now multiprocessing. Seems that we should rather spawn the subprocess a bit later, after having created the Message record.
5 Jahre, 4 Monate ago von Luc Saffre about #269 (test and deploy) : lino_book/projects/noi1e/tests/test_notify.py is failing with "AssertionError: 0 != 1" and I don't yet understand why.
5 Jahre, 5 Monate ago von Luc Saffre about #269 (test and deploy) : pm prep in lydia demo project (Tera) gives "AttributeError: 'str' object has no attribute 'main'". That's my fault.
6 Jahre, 9 Monate ago von Luc Saffre about #269 (test and deploy) : In the default noi settings I changed tickets.end_user_model back to "contacts.Person" because otherwise we have 3 failures in the book test suite. It seems that actually we want end_user to be a person, not any partner. Putting it back to partner was just because of a problem during Jane migration ...
6 Jahre, 9 Monate ago von khchine5 about #269 (test and deploy) : Releasing the following lino packages: openui5 avanti vilma tera noi