#3301 (Maintenance orders and service reports in Noi)

by Luc Saffre · in Developers · assigned to Luc Saffre

Résumé

Concepts sous-jacents

#4640 (Generate invoices via Ticket.order instead of Project.customer) (by Luc Saffre in Developers assigned to Luc Saffre)
#5150 (TypeError: Object of type MissingRow is not JSON serializable) (by Luc Saffre in Developers assigned to Luc Saffre)

Commentaires

3 ans, 9 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : I pushed my work of the last weeks. And now i must hurry up to office...
3 ans, 9 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : I fixed 15 doctests in 24 minutes...
3 ans, 9 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : While writing docs I realized that subscriptions aren't themselves VAT vouchers. It makes no sense that they have a total amount because that amount can potentially change over time. Yet another little avalanche...
3 ans, 10 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : All test suites are finally passing again. Now I "just" need do write an overview of what I did...
3 ans, 10 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : I am almost finished... only ca 20 doctest failures left...
3 ans, 10 mois ago by Luc Saffre in reply to Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : More precisely Josephine Leffin gets an invoice of 20€ every month, but that invoice has no items.
3 ans, 10 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) (1 reply) : (just for myself since my work is not yet pushed:) The test suite (e.g. book/docs/specs/voga/invoicing.rst) reveals that my changes in InvoicingInfo have side effects in Voga. enrolments in non-continuous courses seem to be invoiced twice.
3 ans, 10 mois ago by Luc Saffre in reply to Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : No: reporting_type stays with the project (site).
3 ans, 10 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) (1 reply) : Things look nice. I am excited to see all this in Jane soon! But the avalanche isn't yet finished. reporting_type and group (team) must also move from project (tickets.Site) to the subscription voucher.
3 ans, 10 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : Before pushing my work, I have to fix 50 failures in the book test suite ;-) It's a typical case of avalanche, and Lino ist getting better each time.
3 ans, 10 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : Uff! Lino will have a new plugin "subscriptions", and the Service Level Agreements in Noi will be of this type and no longer done with orders.
3 ans, 10 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : TODO: generate a product for each invoicing area. And probably use a new field Journal.invoicing_product.
3 ans, 10 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : I understood what's happening. I am counting over the existing invoicings to determine whether the next invoice is due. But this goes wrong because (currently) every order generates two invoice lines.
3 ans, 10 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : I am still advancing slowly. Added lots of print statements in order to understand what's happening. Still not yet ready to publish.
3 ans, 10 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : There is still some bug in the algorithm for subscriptions.
3 ans, 10 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : But there is more to do regarding periodicity before I can publish my work.
3 ans, 10 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : Uff, I have first results with the new concepts. The invoicing plugin will now speak about "invoicing states" (a choice list), and follow-up rules are based on these states.
3 ans, 10 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : Also the notion of "invoicing area" needs revision.
3 ans, 10 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : TODO: there is still at least one issue with the invoice generation, causing maintenance availability in 2050 to be invoiced in 2015...
3 ans, 10 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : Yes, #4640 made me understand that we can remove the ServiceReport model.
5 ans, 2 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : I added demo_bookings to noi1e in order to have some invoices in the demo projects. Not yet committed because atm all generated invoices have no amount. And then I will need to adapt some doctests in the book.
5 ans, 2 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : Took some time because we had a few minor surprises. (changelog didn't mention renamed use_verify to something else and support verification_code_sent_on being None)
5 ans, 2 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : Sharif and I are going to upgrade Jane now. In order to play with invoicing.
5 ans, 2 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : The get_invoice_items() methods are no longer responsible for setting the invoiceable field. This is now done by invoicing.Item.create_invoice(), i.e. when executing the invoicing plan.
5 ans, 2 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : The presto demo is currently generating 4323 vouchers instead of 142. It issues each invoice again and again, as if it had not yet been invoiced. I am trying to understand why. The explanation seems to be quite stupid because difficult to find...
5 ans, 2 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : Ha! I understood why presto is still failing. It's because I tried to optimize thing regarding the differentiation between the "partner" and the "invoice recipient". Seems that Presto is just the only demo where this optimization failed because it's the only demo having examples of invoice recipient...
5 ans, 2 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : Orders inherit now from ContactRelated. TODO: "invoiceables from:" is not correctly filled in the first invoice of a periodic order. And then test what these changes did in Presto, Voga and Tera...
5 ans, 2 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : I start to realize what was blocking me with the InvoiceGenerator API : I must remove the get_invoiceable_start_date() and get_invoiceable_end_date() methods and completely move the date filtering logic out to the implementing model. Also I cannot store the period covered by a subscription using the...
5 ans, 2 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : I start to believe that the order items should also contain a unit_price field. An order, at least in Noi, represents a SLA, which may contain individually discussed prices. OTOH in other cases it might be agreed that prices evolve according to tariffs and a public price catalog.
5 ans, 2 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : Lino Noi just did its first periodic invoice :-) That's a good moment to stop working for today.
5 ans, 3 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : I started adding demo data in noi1e. Not a model SubscriptionType but a choicelist Periodicities.
5 ans, 3 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : I won't commit today but I start to see the horizon. We will have a third type of invoice generation "by subscription" and a new model invoicing.SubscriptionType.
5 ans, 3 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : I am still trying to "really" understand how invoicing works. The internal API is suboptimal. It is good that we have an extensive test suite at least for Voga. Tera and Presto are less tested but also important.
5 ans, 3 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : Oops, I started pull.sh on LF but wasn't aware that the demos on LF use the latest git clone and not the PyPI versions. And today I accidentally comitted a change in noi for my work in process. Now the demos on LF are broken until I comitted the other repos as well. But I am not a a working state ye...
5 ans, 3 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : Yes, as expected: the test failure was because I generalized the "invoicing order" concept. In Voga there was only one invoicing area while the default demo fixture creates three invoicing areas. That's the explanation. Now trying to understand why we want three areas at all.
5 ans, 3 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : docs/specs/voga/invoicing.rst is failing after my local changes
5 ans, 3 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : I am trying to reproduce a service report in Jane. At the moment Lino doesn't yield any reasonable results. I will probably dive into this using local print statements to the code on Jane.
5 ans, 3 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : That was because there was no invoicing area defined. The message should be more informative...
5 ans, 3 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : Clicking on Sales --> Create invoices in Jane causes "django.db.utils.IntegrityError: (1048, "Column 'area_id' cannot be null")"
5 ans, 3 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : More precisely Session is already an InvoiceGenerator. And the invoicing plugin (which installs sales) is already in noi. The Order or Agreement model, which is another InvoiceGenerator, is not yet there. Every Site ("Project") that generates invoices would be assigned to an Agreement (and no longer...
5 ans, 3 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : I plan some fundamental changes in the lino_xl.lib.working plugin. Currently the service reports are just printable database objects. I plan to turn them into ledger vouchers that act like invoices, and Session becomes an invoiceable. And to add a another model "Agreement", which is an InvoiceGenera...
6 ans, 1 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : Currently locked because I cannot edit the list of services (Configure Products) in Jane. Maybe a bug in react. Waiting for #3802.
6 ans, 5 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : Started local coding. It's actually quite simple : working.Session becomes InvoiceGenerator. But the devil is in the details. Not yet sure whether we want to add a Sponsoring model.
6 ans, 5 mois ago by Luc Saffre about #3301 (Maintenance orders and service reports in Noi) : I'll work on this now : Turn service reports into vouchers that use up credit. Add a journal for invoices that fill up credit. Time credit is now expressed in euro rather than in hours. Add a model Sponsoring. Move fields company, contact_person and reporting_type from Site to Sponsoring (company an...