by Luc Saffre · in Developers · assigned to Luc Saffre

Summary

Children

Comments

• 6 years, 6 months ago by Luc Saffre about #3569 (Configuring the signers of vouchers) : Funny: [url travis-ci.org/github/lino-framework/amici/jobs/671452399#L1094 this failure] is caused by my orthographic change (it's "Contact person", with a lowercase p)... it is also because in amici on Travis we use the PyPI version. We are not going to make a PyPI release because I fixed a typo.....
• 6 years, 6 months ago by Luc Saffre about #3569 (Configuring the signers of vouchers) : No, the welfare test suites are still disturbed even when we use the last persons as ceo's. The welfare demo suites takes a few persons and makes them directors or CEOs of miscellaneous organizations. The workaround is to use these same persons as CEOs already in XL. For example Annette Arens and Er...
• 6 years, 6 months ago by Luc Saffre about #3569 (Configuring the signers of vouchers) : That's why all our demo CEOs are now living in Paris. Just to avoid breaking too many test cases.
• 6 years, 6 months ago by Luc Saffre about #3569 (Configuring the signers of vouchers) : Took me some time to understand why the cbss test was failing. Partner 116 is Alfons Ausdemwald, whom I made CEO of the site owner and who therefore no longer turned into a client by the welfare demo fixture...
• 6 years, 6 months ago by Luc Saffre about #3569 (Configuring the signers of vouchers) : Oops, Welfare is failing to prep with "Client matching query does not exist" because I changed something in the demo persons. I will look at this asap.
• 6 years, 6 months ago by Luc Saffre about #3569 (Configuring the signers of vouchers) : Seems okay now, only some 13 trivial changes in the book docs.
• 6 years, 6 months ago by Luc Saffre about #3569 (Configuring the signers of vouchers) : A time-consuming subtle challenge: I'd like to show the signers of the site operator in specs/contacts.rst, and this requires some change in the demo persons, but adding a person there causes dozens of doctest failures because the names of persons get shifted...
• 6 years, 6 months ago by Luc Saffre about #3569 (Configuring the signers of vouchers) : Yes, my new implementation looks much better. I started the test suite.
• 6 years, 6 months ago by Luc Saffre about #3569 (Configuring the signers of vouchers) : No, my first implementation isn't good. Not a new model "Signer" but a new attribute for RoleType. And a method Partner.get_signers(today) that returns the contacts.Role for which type__signed=True
• 6 years, 6 months ago by Luc Saffre about #3569 (Configuring the signers of vouchers) : While running the test suite I tried to write docs about this and started reviewing the contacts specs page. What a sisyphean task!
• 6 years, 6 months ago by Luc Saffre about #3569 (Configuring the signers of vouchers) : Seems to work nicely at least for Presto. TODO: adapt tests and publish.
• 6 years, 6 months ago by Luc Saffre about #3569 (Configuring the signers of vouchers) : Add a new model "contacts.Signer(Sequenced)" that basically just points to a contacts.Role and has a class method Signer.get_signers_for_object(obj) that may be overridden per application. The default implementation would simply return the first row. Welfare might extend the model to add the second...