by Luc Saffre · in Developers · assigned to tonis

Résumé

Concepts sous-jacents

Commentaires

• 6 ans, 5 mois ago by Luc Saffre about #3613 (book failing on travis with "error: package directory 'lino_react/projects' does not exist") : I noticed that react had no test_packages.py. I added it. My suggestion to remove lino_react.projects from the packages in setup.py won’t work then. Until now all our repos adhere to the rule that all packages are published in the PyPI as well. Whether this rule is good deserves meditation, but the ...
• 6 ans, 5 mois ago by Luc Saffre about #3613 (book failing on travis with "error: package directory 'lino_react/projects' does not exist") : Tonis, NB Don't use the day as version number. On [url github.com/lino-framework/react/commit/8f4855d70ab48778bee56997d1e90fe70e89fbd0 2020-04-22] you chose 22 as the next minor number (and on 20200427 number 27) but it should have been 2 and 3 respectively. Because there may be several releases a d...
• 6 ans, 5 mois ago by Luc Saffre about #3613 (book failing on travis with "error: package directory 'lino_react/projects' does not exist") : Yes, but it was disturbing me now and I think I see how to fix it... working on it now.
• 6 ans, 5 mois ago by tonis about #3613 (book failing on travis with "error: package directory 'lino_react/projects' does not exist") : Yes.
• 6 ans, 5 mois ago by Luc Saffre about #3613 (book failing on travis with "error: package directory 'lino_react/projects' does not exist") : Can I leave this to you, Tonis?
• 6 ans, 5 mois ago by Luc Saffre about #3613 (book failing on travis with "error: package directory 'lino_react/projects' does not exist") : I'd say that indeed we should remove it from setup_info.py because we don't need these in a source dist. And we can leave them in the repo (and in tasks.py demo_projects) until we are sure that we don't need them any more.
• 6 ans, 5 mois ago by Luc Saffre about #3613 (book failing on travis with "error: package directory 'lino_react/projects' does not exist") : Maybe remove the projects in packages (and in tasks.py demo_projects) because (if I imagine it right) they are no longer needed since we are now testing in the book.
• 6 ans, 5 mois ago by tonis about #3613 (book failing on travis with "error: package directory 'lino_react/projects' does not exist") : That's likely why. In the last version I removed it. IT was like that in your changes which broke the sdist earlier.
• 6 ans, 5 mois ago by Luc Saffre about #3613 (book failing on travis with "error: package directory 'lino_react/projects' does not exist") : Why do you say "prune lino_react/projects" in the MANIFEST.in? I'd guess that this is the reason. At least it contradicts with the 'packages' dict in setup_info.py
• 6 ans, 5 mois ago by tonis about #3613 (book failing on travis with "error: package directory 'lino_react/projects' does not exist") : I was able to get froinde to install the last react OK without that erorr
• 6 ans, 5 mois ago by tonis about #3613 (book failing on travis with "error: package directory 'lino_react/projects' does not exist") : This is caused by the manifest, is it happending on the last version of react too?