by Luc Saffre · in Developers · assigned to khchine5

Summary

Children

Comments

• 6 years, 4 months ago by khchine5 about #3674 (Cannot confirm creation of a client with similar names) : Add more cypress tests
• 6 years, 4 months ago by tonis about #3674 (Cannot confirm creation of a client with similar names) : Fixed. Other than the looping from the form being dirty, ar2js sets pk to be an empty list. Run row action seems to be for only single pk values. Made it so it can take both, and it works.
• 6 years, 4 months ago by tonis about #3674 (Cannot confirm creation of a client with similar names) : Debugged the extjs, it seems that before it runs the action, it want to clean the form first, which is saving the form,which is submitting the form... which causes a confirmation. I think we I need to rework the generated submit_insert code.
• 6 years, 4 months ago by tonis about #3674 (Cannot confirm creation of a client with similar names) : React side is fixed. Problem was in the RP system. There was a RP passed to the runAction method, and due to a logic overside, it hashed the object as assumed it was in the RPstore, but it wasn't (as it was a dialog). Refactored the RP getters and setters and it works 100% in react.
• 6 years, 4 months ago by tonis about #3674 (Cannot confirm creation of a client with similar names) : What's the state of this?
• 6 years, 4 months ago by Luc Saffre in reply to khchine5 about #3674 (Cannot confirm creation of a client with similar names) : No, this was not normal (when you run the action again, the confirmation should come again).
• 6 years, 4 months ago by khchine5 about #3674 (Cannot confirm creation of a client with similar names) : I fixed it. I need to write test case.
• 6 years, 4 months ago by khchine5 about #3674 (Cannot confirm creation of a client with similar names) (1 reply) : If I click NO and try it again, I didn't get the confirmation any more. Is that normal ?
• 6 years, 4 months ago by khchine5 about #3674 (Cannot confirm creation of a client with similar names) : After by confirm action is done , Lino does call the function run_row_action with an wrong API call.
• 6 years, 4 months ago by khchine5 about #3674 (Cannot confirm creation of a client with similar names) : I partially fixed this on the js side
• 6 years, 4 months ago by Luc Saffre about #3674 (Cannot confirm creation of a client with similar names) : Note that test_delete_veto.py (in min9) was already failing 14 days ago. I think it was after a change by Tonis. Maybe this test case would already have revealed the problem. Lesson to learn : after a commit we should always give high priority to getting the test suite pass.
• 6 years, 4 months ago by khchine5 about #3674 (Cannot confirm creation of a client with similar names) : I found that xcallback__"+xcallback.xcallback_id] = xcallback.choice is not set correctly
• 6 years, 4 months ago by khchine5 about #3674 (Cannot confirm creation of a client with similar names) : @tonis I see that the callback param is always still on the server response whatever the action done by the user. Looking at this.
• 6 years, 4 months ago by tonis in reply to khchine5 about #3674 (Cannot confirm creation of a client with similar names) : Actually doesn't matter its in bite form, so long as the comparison works on either side. But I'm seeing in the request made when pressing yes or no doesn't include thst string.
• 6 years, 4 months ago by Luc Saffre about #3674 (Cannot confirm creation of a client with similar names) : Yes, we saw this also in #3305. This is definitively not the intended behaviour but it seems that this doesn't disturb. Before changing any code, please try to write a test case that reproduces the problem. Something similar to test_delete_veto.py in the min9 project. Copy this file to avanti1 proje...
• 6 years, 4 months ago by khchine5 about #3674 (Cannot confirm creation of a client with similar names) (1 reply) : I see that the xcallback_id is en byte format.     "xcallback_id": "b'\\xc9\\xb6k\\nl\\xd8\\xb85xf\\x96\\x0fA\\xf5\\x04S'"
  
• 6 years, 4 months ago by khchine5 about #3674 (Cannot confirm creation of a client with similar names) : Working on this.
• 6 years, 4 months ago by tonis about #3674 (Cannot confirm creation of a client with similar names) : Did a quick check and seems that that the callback confirmation hash isn't being added to the request... But is is for questions like delete... And it seems that the xcallback data is being correctly added to the server response. So I suspect there's some subtle change in the logic flow for this run...
• 6 years, 4 months ago by tonis in reply to Luc Saffre about #3674 (Cannot confirm creation of a client with similar names) : Check the network requests. Is the hash for the question changing with each request or no?
• 6 years, 4 months ago by Luc Saffre about #3674 (Cannot confirm creation of a client with similar names) (1 reply) : A blocking problem. Easily reproducible. I didn't yet find the explanation. Hamza, I assign this to you.