◄ ► | Muuda | Home | Admin | en de fr et | Sign in

#3760 (PrimeReact Fork change review )

by tonis · in Developers

Kokkuvõte

Children

Kommentaarid

  • 6 aastat, 1 kuu ago by tonis about #3760 (PrimeReact Fork change review ) : Fileuploads working. Logic seems to be if you add >1 file to the uploader, it creates many rows, with the same data one for each file. So if you have 5 docs needed to be added, all the same type or whatever, you would upload them with all shared data, then in the grid view likely, edit the discripti...
  • 6 aastat, 1 kuu ago by tonis about #3760 (PrimeReact Fork change review ) : Also did create a PR for the callback things. Was able to work around it, but would be nice if they accept.
  • 6 aastat, 1 kuu ago by tonis about #3760 (PrimeReact Fork change review ) : Success. Jane is back on the NPM version of prime React. I'm seeing some subtle CSS changes, in the <a> color and fonts. But that's not very distubing.
    File uploads still broken.
  • 6 aastat, 1 kuu ago by tonis about #3760 (PrimeReact Fork change review ) : Looking at the docs for PR's grid, they're doing the same logic as before where your modify the entire grid data for each keystroke, and don't have a more complex system of editing. Also tab navigation is broken for their demo.

    Created a issue for the onEditor callbacks. github.com/primefaces/pri...
  • 6 aastat, 1 kuu ago by tonis about #3760 (PrimeReact Fork change review ) : Toolbars are working, along with cards. The Calender field is quite broken though. Seems they've done a fair amount of changes inside of it, mainly to do with what value is rendered. But initially it wouldn't render any values... Used the prototype overrides to put back the older code with the minor...
  • 6 aastat, 1 kuu ago by tonis about #3760 (PrimeReact Fork change review ) : Toolbar issue was because they've changed the system to not use props.children for content rendering, but a left and right prop. Had to add a new CSS rule for having it be block rule, so that we can have the action buttons on a separate line then the nav buttons.
  • 6 aastat, 1 kuu ago by tonis about #3760 (PrimeReact Fork change review ) : Autocomplete keydown, easy fix, was able to capture the keydown inside a parent div. Seems that the new theme has messed up some of the CSS or something. Main issues are toolbar for details not rendering Card display not full width. Working on getting dialogs working again. Seems they've changed the...
  • 6 aastat, 2 kuud ago by tonis about #3760 (PrimeReact Fork change review ) : Onkeydown callback for autocompletle Dialog global binding needs to be unbound when you have multiple dialogs. This might have been dixed. Or is worth doing a PR on.
    d262b5e680325cd304a46c387a5e5f9f1dbf3365 Seems to deal with value issues with date / time choosers, they were buggy when wanting to pr...
  • 6 aastat, 2 kuud ago by tonis about #3760 (PrimeReact Fork change review ) : Think I lost my old comment. Updated tickets to have a todo list type thing. Going to add features there and check them off as they are 'fixed'
    Main one is the ability to navigate via [return] when editing a table. DOMhandler, -> used only in linoDialog? onEditorOpen callback 40a441b6db0355219f43f...