#4026 (Issues with grid edit in React)

by Luc Saffre · in Developers · assigned to Sharif Mehedi

Résumé

Reproducible e.g. in noi1r demo project. Edit some grid cell. Hit ENTER to submit your change. Cell editor stops, but oops! it shows the old value. When you hit the Refresh button, it gets updated and your change becomes visible. Also (maybe related): when you click on another editable cell, the cell editor shows the value of the previous cell for a short moment.

Concepts sous-jacents

Commentaires

  • 5 ans, 7 mois ago by Sharif Mehedi about #4026 (Issues with grid edit in React) : One ticket down. many more to go.
  • 5 ans, 7 mois ago by Luc Saffre about #4026 (Issues with grid edit in React) : Wow, seems that you found the real cause of the problem!
  • 5 ans, 7 mois ago by Sharif Mehedi about #4026 (Issues with grid edit in React) : I patched it properly this time. And made a PR. As I was exploring more, I found out that (a correction to my comment #5678), the BodyCell props were flowing downward to LinoLayout and more, not as unpacked props but grouped or packed in a single prop with the name(s) column, columnProps (in differen...
  • 5 ans, 7 mois ago by Luc Saffre about #4026 (Issues with grid edit in React) : Sharif, I could not see any improvement on this after pulling your PR. Should we have another look at this together?
  • 5 ans, 7 mois ago by Sharif Mehedi about #4026 (Issues with grid edit in React) : I found out that on onSubmit method in LinoGrid - the key rowIndex that is suppose to update the LinoGrid.state.rows was undefined. That's why the the editors latest value weren't updating until refresh. My fix depends on the ID column (column of Index 0) of each row, as long as we stick to put the I...