by Sharif Mehedi · in Developers · assigned to Sharif Mehedi

Summary

Children

Comments

• 5 years, 6 months ago by Sharif Mehedi about #4080 (TextEditor Suggestor does not return any suggestions, similar to ticket #3041) : Thank you @luc, But there's also this failure: ========================================================= python -m doctest docs/specs/noi/memo.rst ---------------------------------------------------------- >>>print(ses.parse_memo("See #1.")) Expected:    See <a href="Detail" title="F&#246;&#2...
• 5 years, 6 months ago by Luc Saffre about #4080 (TextEditor Suggestor does not return any suggestions, similar to ticket #3041) : I did manual tests and it seems to work, even better than before. I close this ticket.
• 5 years, 6 months ago by Luc Saffre about #4080 (TextEditor Suggestor does not return any suggestions, similar to ticket #3041) : Well done, @8lurry !
• 5 years, 6 months ago by Sharif Mehedi about #4080 (TextEditor Suggestor does not return any suggestions, similar to ticket #3041) : I will work on that now.
• 5 years, 6 months ago by Luc Saffre about #4080 (TextEditor Suggestor does not return any suggestions, similar to ticket #3041) : So this failure is actually a confirmation of your change. And I confirm that we don't use suggestors in ExtJS. So you should now adapt that file in the book to make the doctest pass again.
• 5 years, 6 months ago by Sharif Mehedi about #4080 (TextEditor Suggestor does not return any suggestions, similar to ticket #3041) : I changed that to match the quill mention's data structure. This is from commit history: github.com/lino-framework/lino/commit/741b47819c287df5d4a8d55754393e2faf2704bb
• 5 years, 6 months ago by Luc Saffre about #4080 (TextEditor Suggestor does not return any suggestions, similar to ticket #3041) : There are now some failures when we say "doctest docs/specs/noi/memo.rst" in the book repository. They seem to be caused by this ticket. Sharif and I should have a look at it together. For example:
  File "docs/specs/noi/memo.rst", line 206, in memo.rst Failed example:    list(mp.suggesters['@'].get_...
• 5 years, 6 months ago by Sharif Mehedi about #4080 (TextEditor Suggestor does not return any suggestions, similar to ticket #3041) : Quill-mention is working properly internally. But has rendering issue, side effect of #4083 .
  
• 5 years, 6 months ago by Luc Saffre about #4080 (TextEditor Suggestor does not return any suggestions, similar to ticket #3041) : Sharif and I had a productive Jitsi session. We moved the Suggestions view (which returns the suggestions for a given trigger char) from the react plugin to the memo plugin. The [url github.com/afry/quill-mention quill-mention module] seems great, our whole Suggester.js file has become useless.
• 5 years, 6 months ago by Sharif Mehedi about #4080 (TextEditor Suggestor does not return any suggestions, similar to ticket #3041) (1 reply) : react-input-trigger {InputTrigger} component does not support multiple trigger keys, @tonis did a fork of the component and made some changes to it so that it supports multiple trigger keys (i.e. "@", "#") . But now we are using the original react-input-trigger again, also there are some compatibili...