by Luc Saffre · in Developers · assigned to Luc Saffre

Kokkuvõte

Children

• #4887 (Replying to a comment doesn't set the owner) (by Luc Saffre in Developers assigned to Luc Saffre)

Kommentaarid

• 2 aastat, 10 kuud ago by Luc Saffre about #4084 (Comment.owner is empty when replying to a comment) : I published my changes. Done.
• 2 aastat, 10 kuud ago by Luc Saffre about #4084 (Comment.owner is empty when replying to a comment) : Seems that it's done. But there will be some doctest failures because we have a new data checker. I started the test suite before publishing my changes.
• 2 aastat, 10 kuud ago by Luc Saffre about #4084 (Comment.owner is empty when replying to a comment) : I wrote the data checker and found why we still have new reply comments in Jane without an owner: CommentField.set_value_in_object() didn't call full_clean().
• 2 aastat, 10 kuud ago by Luc Saffre about #4084 (Comment.owner is empty when replying to a comment) : The issue is still there. I plan to write a data checker.
• 2 aastat, 11 kuud ago by Luc Saffre about #4084 (Comment.owner is empty when replying to a comment) : It's difficult to work on this as long as the CommentsByRFC is sick (#5257)...
• 2 aastat, 11 kuud ago by Luc Saffre about #4084 (Comment.owner is empty when replying to a comment) : I had pushed a quick fix, but that fix wasn't tested and turned out to actually break it :-). I now fixed it.
• 2 aastat, 11 kuud ago by Luc Saffre about #4084 (Comment.owner is empty when replying to a comment) : The issue is still there in Jane. So what?
• 5 aastat, 6 kuud ago by Luc Saffre about #4084 (Comment.owner is empty when replying to a comment) : I reproduced it locally on noi1e, fixed the problem, then verified manually that it is fixed. How to reproduce: log in as robin, click on a ticket. Write a comment on that ticket. Click on the comment to show its detail. Write a reply to your comment. Then click on the detail of your reply and check...
• 5 aastat, 6 kuud ago by Luc Saffre about #4084 (Comment.owner is empty when replying to a comment) : When replying to a comment, the new comment has reply_to filled out correctly, but the owner is empty. Should be the same as the original comment. Also add a data checker to fix existing data.