by Luc Saffre · in Developers · assigned to Luc Saffre

Summary

Children

Comments

• 5 years, 3 months ago by Luc Saffre about #4243 (Old suggested events don't get deleted after changing Course.start_date) : Ha! I added yet another test to test_faggio.py, which reproduces my original issue. The issue is still there, but now it will be easier because I have something top work on.
• 5 years, 3 months ago by Luc Saffre about #4243 (Old suggested events don't get deleted after changing Course.start_date) : I added two more edge cases in test_faggio.py.
• 5 years, 3 months ago by Luc Saffre about #4243 (Old suggested events don't get deleted after changing Course.start_date) : Yes, EventGenerator is a complex topic. But I start to see horizon...
• 5 years, 3 months ago by Luc Saffre about #4243 (Old suggested events don't get deleted after changing Course.start_date) : Two failures after my local changes... and they aren't trivial ones...
• 5 years, 3 months ago by Luc Saffre about #4243 (Old suggested events don't get deleted after changing Course.start_date) : I did some fundamental changes to the EventGenerator.update_auto_events() method. Biggest problem was that until now it didn't imagine that there might be duplicate sequence numbers in the series of automatic events.
• 5 years, 3 months ago by Luc Saffre about #4243 (Old suggested events don't get deleted after changing Course.start_date) : Oh, automatic calendar event generation is so tricky! I started to review the docs because they are far from being clear. And I probably found another bug: seems that my example in froinde generates duplicate events.
• 5 years, 3 months ago by Luc Saffre about #4243 (Old suggested events don't get deleted after changing Course.start_date) : This is going to be a change in EventGenerator.get_wanted_auto_events(), a complex piece of code. I need to be careful. Fortunately the test coverage is relatively good. I now have something that might work , but the biggest work is to write a test case.