by Sharif Mehedi · in Developers

Summary

Children

Comments

• 4 years, 9 months ago by Sharif Mehedi in reply to Luc Saffre about #4410 (Scrutinizing some users.User and contacts.Person attributes.) : I changed the label, and ran all the test suite and adjusted them accordingly. Basically found failures in book and welfare and fixed them.
• 4 years, 9 months ago by Luc Saffre in reply to Luc Saffre about #4410 (Scrutinizing some users.User and contacts.Person attributes.) : Yes, that would be good. But do it in a clean copy of the repo and when the test suite is passing, because this trivial change will probably cause some trivial failures.
• 4 years, 9 months ago by Sharif Mehedi in reply to Luc Saffre about #4410 (Scrutinizing some users.User and contacts.Person attributes.) : The label is GSM, should I change it to "Mobile"?
• 4 years, 9 months ago by Luc Saffre in reply to Sharif Mehedi about #4410 (Scrutinizing some users.User and contacts.Person attributes.) (3 replies) : Thanks for the comment. The fieldname "gsm" can be considered a historic misnomer. Actually it should be "mobile". In Belgium most people say "GSM" for "Mobile phone". I am a bit reluctant to change the internal field name because this increases complexity when migrating existing data. But the label...
• 4 years, 9 months ago by Sharif Mehedi about #4410 (Scrutinizing some users.User and contacts.Person attributes.) (1 reply) : I have another query about an attribute from contacts.Person which comes from Phonable. This attribute is Phonable.gsm. Did a little study and as far as I can see, GSM stands for global system for mobile communication which also was European standard for mobile communication (with 2G bandwidth). The...
• 4 years, 9 months ago by Luc Saffre about #4410 (Scrutinizing some users.User and contacts.Person attributes.) : E.g. when a worker leaves their job, but the user account remains. Sometimes it is preferrable to handle this by setting the end date.
• 4 years, 9 months ago by Sharif Mehedi about #4410 (Scrutinizing some users.User and contacts.Person attributes.) : I am wondering why we need DateRange which comes with User.start_date and User.end_date in User model. Also cal.models injects two fields into User these are 'access_class' and 'event_type'. I am wondering why we need the DateRange and also think that managing 'access_class' and 'event_type' in some...