by Luc Saffre · in Developers · assigned to Sharif Mehedi

Summary

Children

• #4441 (React dynamic display mode (Actor.get_display_mode(ar))) ( 35 by Sharif Mehedi in Developers assigned to Sharif Mehedi)

Comments

• 4 years, 8 months ago by Sharif Mehedi about #4438 (Optimize CommentsByRFC) : At the moment the display_mode is hard coded on json cache files. To depend on ar to get a display_mode, I suppose we will have to do some minor redesign.
• 4 years, 8 months ago by Luc Saffre about #4438 (Optimize CommentsByRFC) : I currently think that we rather need a default_display_mode that maps a window_type to a display mode. Maybe even a callable method get_display_mode(ar).
• 4 years, 8 months ago by Sharif Mehedi about #4438 (Optimize CommentsByRFC) : When I set CommentsByRFC.display_mode to constants.DISPLAY_MODE_STORY, the CommentsByRFC slave_summary_panel in the ticket detail also turned into a StoryElement (which we do not want to happen). To mitigate this issue I am thinking of having another actor attribute slave_display_mode, OR we can do ...
• 4 years, 8 months ago by Sharif Mehedi about #4438 (Optimize CommentsByRFC) : pk_index mismatches due to the fact that we have store.PreviewTextStoreField.list_values_count set to 3. And row2list did not account for previewable_fields until now. But now that row2list accounts for previewable_fields, there are redundant _short_preview -s, _full_preview -s, also the actorData.c...
• 4 years, 8 months ago by Sharif Mehedi about #4438 (Optimize CommentsByRFC) : For some reasons (unknown at the moment), the pk_index is not matching with the actual position of pk in the row_list.
• 4 years, 8 months ago by Luc Saffre about #4438 (Optimize CommentsByRFC) : Tooltips of the display mode buttons. The default display mode should show the comment texts and visualize their hierarchy. Switching display modes currently can cause the browser to "freeze". The detail view was creating a lot of AJAX requests.