#4508 (Side effects when pyvat fails to validate demo a VAT number)

by Luc Saffre · in Developers · assigned to Luc Saffre

4 ans, 3 mois ago by Luc Saffre about #4508 (Side effects when pyvat fails to validate demo a VAT number) : We did already have the use_online_check plugin setting. We were using it on pierre and roger, I now removed in from roger. One demo project having it on should be enough. I also changed the implementation: the VatIdChecker now exists also when use_online_check is set to False. And it also calls val...
4 ans, 5 mois ago by Luc Saffre about #4508 (Side effects when pyvat fails to validate demo a VAT number) : doctest docs/specs/checkdata.rst shows that right now the VAT server for Germany is still unavailable. Soso. Which raises the question: should we add an "offline" plugin option and disable these validations altogether in our test suite? After all it's actuallly not very nice that we are using these ...
4 ans, 5 mois ago by Luc Saffre about #4508 (Side effects when pyvat fails to validate demo a VAT number) : I guess that it is related to the VatNumberManager.generate_vid(), i.e. I should dive into this together with Sharif.
4 ans, 5 mois ago by Luc Saffre about #4508 (Side effects when pyvat fails to validate demo a VAT number) : The following traceback happened tonight during the test run, and I think I have seen it on GitLab as well. It seems to come when some national VAT service was not available when pyvat tried to validate our fictive demo VAT numbers. Which it does at least in docs/specs/checkdata.rst. And I now suspe...