by Luc Saffre · in Developers · assigned to Sharif Mehedi

Kurzbeschreibung

Kinder

Kommentare

• 3 Jahre, 11 Monate ago von Luc Saffre about #4593 (Jane still imports commits from GitHub instead of GitLab) : I adapted the test suite and pushed my work.
• 3 Jahre, 11 Monate ago von Luc Saffre about #4593 (Jane still imports commits from GitHub instead of GitLab) : I started to remove the github plugin from noi. (actually only 2 places in the code), but causing 12 test failures in book.
• 4 Jahre, 2 Monate ago von Sharif Mehedi Antwort auf Luc Saffre about #4593 (Jane still imports commits from GitHub instead of GitLab) : Yes you are right. This idea seems more effective and plausible from the context of system design.
• 4 Jahre, 2 Monate ago von Luc Saffre Antwort auf Sharif Mehedi about #4593 (Jane still imports commits from GitHub instead of GitLab) (1 Antwort) : I am reluctant to such auto-generated comments. The Comment model should be reserved for real comments, written by humans. If we create a comment for every commit, we should also create a comment for e.g. for every change, or for every work session. Instead of generating comments for each "miscellan...
• 4 Jahre, 2 Monate ago von Luc Saffre Antwort auf Sharif Mehedi about #4593 (Jane still imports commits from GitHub instead of GitLab) : I fully agree.
• 4 Jahre, 2 Monate ago von Sharif Mehedi Antwort auf Luc Saffre about #4593 (Jane still imports commits from GitHub instead of GitLab) : Instead of connecting to repo-base every hour, we can have triggers on gitlab cd/ci pipeline that will send the commit to jane, and jane will simply store the commit into the database.
• 4 Jahre, 2 Monate ago von Sharif Mehedi about #4593 (Jane still imports commits from GitHub instead of GitLab) (1 Antwort) : An Idea is that we can show a commit as a comment in the ticket detail so that the ticket history, regards to code changes, are more understandable.
• 4 Jahre, 2 Monate ago von Sharif Mehedi about #4593 (Jane still imports commits from GitHub instead of GitLab) (1 Antwort) : we should probably rename the github plugin to "git" plugin.
• 4 Jahre, 2 Monate ago von Luc Saffre about #4593 (Jane still imports commits from GitHub instead of GitLab) (1 Antwort) : Jane is currently connecting every hour to GitLab asking for new commits on every repository. Seems that lino_xl.lib.github needs a revision.