#4726 (The "Calendar entries" panel has no open-in-own-window button)
by Luc Saffre · in Developers · assigned to Sharif Mehedi
Summary
Children
- #4752 (Cannot show the detail of an enrolment under react) (by Luc Saffre in Developers assigned to Luc Saffre)
Comments
- 3 years, 9 months ago by Sharif Mehedi about #4726 (The "Calendar entries" panel has no open-in-own-window button) : This is fixed now, from some other ticket. Since we had multiple similar issues.
- 3 years, 10 months ago by Luc Saffre about #4726 (The "Calendar entries" panel has no open-in-own-window button) : I still see the problem. For example runserver in roger, sign in as robin, go to 127.0.0.1:8000/#/api/courses/Pupils/145?tab=2 ("Activities" tab in the detail view of a participant). The "Enrolments in Activities:" panel has no way to open it in a separate window.
- 3 years, 10 months ago by Sharif Mehedi about #4726 (The "Calendar entries" panel has no open-in-own-window button) : We can consider this ticket closed and am putting it to closed.
- 3 years, 10 months ago by Sharif Mehedi about #4726 (The "Calendar entries" panel has no open-in-own-window button) : the code looks fine. Calendar Entries should be a SlaveSummaryPanel, which it is - on my local dev environment.
- 3 years, 10 months ago by Sharif Mehedi about #4726 (The "Calendar entries" panel has no open-in-own-window button) : the code looks fine. Calendar Entries should be a SlaveSummaryPanel, which it is - on my local dev environment.
- 3 years, 10 months ago by Sharif Mehedi about #4726 (The "Calendar entries" panel has no open-in-own-window button) : But why? it says DISPLAY_MODE_SUMMARY, but still it's an HtmlBoxElement on the actorData.
- 3 years, 10 months ago by Sharif Mehedi about #4726 (The "Calendar entries" panel has no open-in-own-window button) : EntriesByCourse is an HtmlBoxElement
- 3 years, 10 months ago by Luc Saffre about #4726 (The "Calendar entries" panel has no open-in-own-window button) : I uploaded two screenshots with a surprising observation: the "Invoicing" tab of client 114 in noereth looks differently on my local machine than on the (prototype) production site for soshilfe. On the prod site the slave panel "OrdersByClient" is rendered with a header bar and a open-in-own-window ...
- 3 years, 10 months ago by Luc Saffre about #4726 (The "Calendar entries" panel has no open-in-own-window button) : I think I understood the problem: a SlaveContainer has no open-in-own-window button. But it probably should have one, similar to the one in SlaveSummaryPanel. Compare their render() methods in LinoComponents.js
- 3 years, 10 months ago by Luc Saffre about #4726 (The "Calendar entries" panel has no open-in-own-window button) : I am fishing in the dark.... I tried adding a line LinoComponents.ReactiveElement = LinoComponents.SlaveSummaryPanel; in the LinoComponents.js file but that didn't help. I now think that this might be a regression introduced with the SlaveContainer, i.e. the client-side selection of display mode.
- 3 years, 10 months ago by Luc Saffre about #4726 (The "Calendar entries" panel has no open-in-own-window button) : The EntriesByCourse panel of the detail of the Greece journey has no such button (which has pi-external-link as icon class) and no header. It should be a SlaveSummaryPanel, but obviously isn't. And I don't understand why.
- 3 years, 10 months ago by Luc Saffre about #4726 (The "Calendar entries" panel has no open-in-own-window button) : Created a new Ticket.