#4746 (keep search query in the url & review SlaveContainer feature.)
by Sharif Mehedi · in Developers · assigned to Sharif Mehedi
Kokkuvõte
Children
Kommentaarid
- 3 aastat, 10 kuud ago by Sharif Mehedi about #4746 (keep search query in the url & review SlaveContainer feature.) : The issue was coming from using a deprecated method Actor.request_from (which doesn't btw put the ar.request into sar.request) and instead we now use Actor.request(parent=ar, **kwargs).
- 3 aastat, 10 kuud ago by Sharif Mehedi in reply to Sharif Mehedi about #4746 (keep search query in the url & review SlaveContainer feature.) : It was actually coming from param_defaults() , in some cases, we are setting defaults by calling ar.get_user() which sometimes sets it to AnonymousUser , I am not yet sure how to solve this, although I already wrote a solution but I am not confident about it. let's talk about it on a live meeting.
- 3 aastat, 10 kuud ago by Luc Saffre in reply to Sharif Mehedi about #4746 (keep search query in the url & review SlaveContainer feature.) : I don't seem to agree. Querying the messages with user=None will return all messages. We prefer an error rather than data leak.
- 3 aastat, 10 kuud ago by Sharif Mehedi about #4746 (keep search query in the url & review SlaveContainer feature.) (2 replies) : There's a pitfall, ar.get_user() may return Anonymous() user. And passing Anonymous() user in a query results in failure. In such cases the value should be None instead of Anonymous() user. This failure occurs when I try to load noi1r in mobile view with system.use_dashboard_layouts set to True.
- 3 aastat, 10 kuud ago by Sharif Mehedi about #4746 (keep search query in the url & review SlaveContainer feature.) : Created a new Ticket.