by Luc Saffre · in Developers · assigned to Luc Saffre

Summary

Children

Comments

• 3 years, 7 months ago by Sharif Mehedi about #4905 (Cannot join existing household) : I am not sure what you did on this. Now it seems there are some unnecessary and ineffective code from both of our changes. Let's talk about this.
• 3 years, 7 months ago by Luc Saffre about #4905 (Cannot join existing household) : I changed the get_row_edit_lines() so that it always sets mk and mt when there is a master_field. I removed the ForeignKeyElement.store_options() method because I didn't see its purpose. I simplified the enable listener in linoweb.js. Seems that it works now in both cases.
• 3 years, 7 months ago by Luc Saffre about #4905 (Cannot join existing household) : Hint for tomorrow: look at extjs.Plugin.get_row_edit_lines().
• 3 years, 7 months ago by Luc Saffre about #4905 (Cannot join existing household) : Oh shit: even with your latest change I still have the problem at another place: in demo project gerd when I sign in as robin, the click on the name of some client in the dashboard to open the detail, then activate the "Competences" tab, in the "Skills" panel doubleclick on a cell in the "Property" ...
• 3 years, 7 months ago by Luc Saffre about #4905 (Cannot join existing household) : Wow, you are better than in finding a solution in other people's code! I will now dive into this and try to find an easier solution.
• 3 years, 7 months ago by Sharif Mehedi about #4905 (Cannot join existing household) : I finally got this working. pull lino to see the effects.
• 3 years, 7 months ago by Sharif Mehedi about #4905 (Cannot join existing household) : I am still trying to figure this out. give some more time.
• 3 years, 7 months ago by Luc Saffre about #4905 (Cannot join existing household) : Sharif, any news about this? I just stumbled into another case where it happens under extjs. We must either add mk to the parameters of the request emited by a combobox, or remove the BadRequest check for /choices/ requests. The former would be better, but it needs diving into extjs.
• 3 years, 7 months ago by Luc Saffre about #4905 (Cannot join existing household) : The exception is actually correct, it comes because Lino is more sever now But a /choices/ request until some weeks ago was allowed to have no master. Sharif has already adapted react so that it sends mk and mt. He will also try to adapt extjs.
• 3 years, 7 months ago by Sharif Mehedi about #4905 (Cannot join existing household) : but it does not yet work in extjs. There problem in on the frontend.
• 3 years, 7 months ago by Sharif Mehedi about #4905 (Cannot join existing household) : I found the problem in react. I don't know how long it has been there. but it's a stupid bug. React still need a lot of work.
• 3 years, 7 months ago by Sharif Mehedi about #4905 (Cannot join existing household) : That's a good idea.
• 3 years, 7 months ago by Luc Saffre about #4905 (Cannot join existing household) : To see a working version, maybe it would be usefull to checkout a series of repositories from some months ago by running "pp git checkout..." as explained [url stackoverflow.com/questions/6990484/how-to-checkout-in-git-by-date#6990682 here].
• 3 years, 7 months ago by Luc Saffre in reply to Luc Saffre about #4905 (Cannot join existing household) : No no, this action works and is being used in welfare and avanti and amici. The master_instance is the person. The action is a window action (i.e. before the ajax it opens a popup and asks for parameters).
• 3 years, 7 months ago by Luc Saffre about #4905 (Cannot join existing household) : I will now commit my local changes because so that we work synched.
• 3 years, 7 months ago by Luc Saffre about #4905 (Cannot join existing household) : Sharif, do you remember to have changed something that might have caused this? I have a feeling that it was you (but just a feeling).
• 3 years, 7 months ago by Luc Saffre about #4905 (Cannot join existing household) : The same problem also causes the doctest failure in docs/specs/households.rst when it calls households.MembersByPerson.insert. And this helps us to understand the reason: the base_params haven't been passed. We just need to find out which change caused this doctest failure.
• 3 years, 7 months ago by Luc Saffre about #4905 (Cannot join existing household) (6 replies) : go amici1; runserver; sign in as robin;oppen some client detail; switch to "Family" tab; click "Join an existing household"; in the insertw window try to select a household. Lino then says: AjaxExceptionResponse BadRequest: Request on slave table households.MembersByPerson has no master instance (.....
• 3 years, 7 months ago by Luc Saffre about #4905 (Cannot join existing household) : Created new Ticket #4905 (Cannot join existing household).