#5065 (Optimize "Showing X of Y rows")

50 · by Luc Saffre · in Developers · assigned to Sharif Mehedi

Kurzbeschreibung

Kinder

Kommentare

3 Jahre, 1 Monat ago von Luc Saffre about #5065 (Optimize "Showing X of Y rows") : We saw together that on my machine there is some bug when computing the number of rows. But we couln't reproduce it on Sharif's machine.
3 Jahre, 1 Monat ago von Luc Saffre about #5065 (Optimize "Showing X of Y rows") : Put the paginator bar at the top by default.
3 Jahre, 2 Monate ago von Luc Saffre about #5065 (Optimize "Showing X of Y rows") : Basically it works, but it seems to me that the handleZoom() function needs more optimization. We would like to have no scroll bar after hitting Ctrl+ or Ctrl- because the number of rows should be what fits to the screen.
3 Jahre, 2 Monate ago von hannes about #5065 (Optimize "Showing X of Y rows") : Upgrade: jane to 23.8.0 This time all ran smoothly, no more pm makehelp error.
3 Jahre, 2 Monate ago von Luc Saffre Antwort auf hannes about #5065 (Optimize "Showing X of Y rows") : Yes, this is probably #4767
3 Jahre, 2 Monate ago von Luc Saffre about #5065 (Optimize "Showing X of Y rows") : @8lurry let's have a jitsi session to play with the new feature.
3 Jahre, 2 Monate ago von Luc Saffre about #5065 (Optimize "Showing X of Y rows") : Yes, the failing makehelp doesn't disturb us, it just means that the local help pages haven't been updated.
3 Jahre, 2 Monate ago von hannes about #5065 (Optimize "Showing X of Y rows") (1 Antwort) : Froinde seems to be up again, but probably with help files there should something to be fixed
3 Jahre, 2 Monate ago von Sharif Mehedi about #5065 (Optimize "Showing X of Y rows") (1 Antwort) : I just released lino, xl and noi to pypi.
3 Jahre, 2 Monate ago von Sharif Mehedi about #5065 (Optimize "Showing X of Y rows") : I have no local changes on lino and xl. And I am confident about the current implementation of it. I think we are good to go and can let the customers test it out.
3 Jahre, 2 Monate ago von Luc Saffre about #5065 (Optimize "Showing X of Y rows") : Great! I suuggest that we pull it to Jane and Froinde before letting the customer test it. IOW Sharif, please also release lino and xl and noi to pypi (if needed) and then Hannes please upgrade Jane and Froinde.
3 Jahre, 2 Monate ago von Sharif Mehedi about #5065 (Optimize "Showing X of Y rows") : sorry about that, my bad. it's fixed now. FYI, I released the corrected version of react to pypi
3 Jahre, 2 Monate ago von Luc Saffre about #5065 (Optimize "Showing X of Y rows") : Cool! Looks nice! But it interfers with the manual rowsPerPage field. Hitting the + or - has no effect.
3 Jahre, 2 Monate ago von Sharif Mehedi about #5065 (Optimize "Showing X of Y rows") : On zoom, react now updates the dataTable. I released react to pypi as well.
3 Jahre, 2 Monate ago von Luc Saffre about #5065 (Optimize "Showing X of Y rows") : We can simplify the problem by assuming that the grid cells do not wrap over more than one line of text. You can then compute the number of rows from the window height and the font size. ExtJS does something similar.
3 Jahre, 2 Monate ago von Luc Saffre about #5065 (Optimize "Showing X of Y rows") : The customer suggests that Lino automatically (1) adapts the number of rows per page and (2) reloads the page when they hit Ctrl+ or Ctrl- to zoom in or out.
3 Jahre, 2 Monate ago von Luc Saffre about #5065 (Optimize "Showing X of Y rows") (1 Antwort) : There is a line "preview_limit = settings.SITE.preview_limit" in lino.core.tables, and I guess that this is bullshit.
3 Jahre, 2 Monate ago von Luc Saffre about #5065 (Optimize "Showing X of Y rows") : Aha. Okay, if that's the case, then let's use preview_limit for this situation as well. But when Actor.preview_limit is None, Lino should take Site.preview_limit as default value. And that value is set to 90 on their site. But they still get 15 as default value for rowsPerPage.
3 Jahre, 2 Monate ago von Sharif Mehedi about #5065 (Optimize "Showing X of Y rows") : we do have the possibility to set the default value on each actor. See [url gitlab.com/lino-framework/lino/-/blob/master/lino/core/actors.py?ref_type=heads#L449 this option]
3 Jahre, 2 Monate ago von Luc Saffre about #5065 (Optimize "Showing X of Y rows") : It is getting better, but IMHO we also need a possibility to locally change that default value (15) for all lists of clients (i.e. all actors working on model avanti.Client).
3 Jahre, 2 Monate ago von Sharif Mehedi about #5065 (Optimize "Showing X of Y rows") : @luc , test it out now and you may close this ticket if everything feels alright to you.
3 Jahre, 2 Monate ago von Sharif Mehedi about #5065 (Optimize "Showing X of Y rows") : Hitting the refresh resets the Paginator. I will tell it not to reset and I will have the HashRouter registers the parameters from the Paginator as a part of the current URL. See: #5019 .
3 Jahre, 2 Monate ago von Sharif Mehedi about #5065 (Optimize "Showing X of Y rows") : We already have Site option as well as Actor option `preview_limit`. Which is set to 15 as the default value, look at the site.py
3 Jahre, 2 Monate ago von Luc Saffre about #5065 (Optimize "Showing X of Y rows") : Or Lino might compute the number of rows from the hieght of the browser window.
3 Jahre, 2 Monate ago von Luc Saffre about #5065 (Optimize "Showing X of Y rows") : Where does the default value 15 come from? Make it configurable as an actor class attribute.
3 Jahre, 2 Monate ago von Luc Saffre about #5065 (Optimize "Showing X of Y rows") : Or maybe customize their list view and use this as the default display mode.
3 Jahre, 2 Monate ago von Luc Saffre about #5065 (Optimize "Showing X of Y rows") : Maybe we can set the default value per site per actor in the local settings.py.
3 Jahre, 2 Monate ago von Luc Saffre about #5065 (Optimize "Showing X of Y rows") : When I hit refresh, it goes back to 15 rows.
3 Jahre, 2 Monate ago von Sharif Mehedi about #5065 (Optimize "Showing X of Y rows") : We have a slider on the paginator.
3 Jahre, 2 Monate ago von Luc Saffre about #5065 (Optimize "Showing X of Y rows") : Add the value 15 to the combobox? Turn the combobox into a slider. They potentially want to show 13 or 17 lines.
3 Jahre, 2 Monate ago von Luc Saffre about #5065 (Optimize "Showing X of Y rows") (1 Antwort) : Let me show you a few issues during our next meeting.
3 Jahre, 2 Monate ago von Luc Saffre about #5065 (Optimize "Showing X of Y rows") : Created new Ticket #5065 (Optimize "Showing X of Y rows").