#5239 (Document & test the React front end)

40 · by Sharif Mehedi · in Developers · assigned to Sharif Mehedi

Résumé

Concepts sous-jacents

Commentaires

10 mois ago by Sharif Mehedi about #5239 (Document & test the React front end) : Even with optimized cache loading, the jsdom tests are failing to run on gitlab.
10 mois ago by Sharif Mehedi about #5239 (Document & test the React front end) : I just published another optimization. Let's see if the react test suite run on gitlab (link).
10 mois, 1 semaine ago by Sharif Mehedi about #5239 (Document & test the React front end) : Setting up a testing environment in jsdom, using react-testing-library, msw (Mock Service Worker) and jest requires some careful consideration. One drawback that I am facing right now is that, msw is not compatible with whatwg-fetch. We can use window.fetch (the Fetch API) when available, but curren...
10 mois, 1 semaine ago by Luc Saffre about #5239 (Document & test the React front end) : Review and update the docs of the react repository (react.lino-framework.org) where needed.
10 mois, 2 semaines ago by Sharif Mehedi about #5239 (Document & test the React front end) : The browser based testing is probably not very efficient. I will try loading react into the react-testing-library (in a jsdom environment), I will have to write a lot of Mock(s). Starting from Storage (window.localStorage) to IndexedBD and all the api calls that react makes. It will need some work b...
1 année, 5 mois ago by Sharif Mehedi about #5239 (Document & test the React front end) : it looks like the jest test suite is too slow on a single core cpu.
1 année, 9 mois ago by Luc Saffre about #5239 (Document & test the React front end) : Add your lock file to git and adapt [url react.lino-framework.org/guide/start.html Quick start].
2 ans, 2 mois ago by Luc Saffre about #5239 (Document & test the React front end) : I pushed [url gitlab.com/lino-framework/react/-/commit/2d8096b22b2ca9841b480c5834c867af2a789db7 my first changeset in react]. The only real change is that i removed the "Pinned URL(s)" button from the toolbar of the main page. I also released it to PyPI (as an exercise for me).
2 ans, 2 mois ago by Luc Saffre about #5239 (Document & test the React front end) : I am ready to release react to pypi... but how to tell git to that all those old generated js files have been replaced by the new ones?
2 ans, 2 mois ago by Luc Saffre about #5239 (Document & test the React front end) : Today I started to play more boldly in GridElement.jsx, right now i am trying to move the code in editNextCell to a new handler onRowEditComplete because I have the feeling that onKeyDown is not the right place to handle this....
2 ans, 2 mois ago by Luc Saffre about #5239 (Document & test the React front end) : Yes, that was the explanation. Lino works with PR version 10.6 and doesn't work with version 10.8, so now the next step is to find a solution. Detail in my [url luc.lino-framework.org/blog/2024/0820.html today blog post].
2 ans, 2 mois ago by Luc Saffre about #5239 (Document & test the React front end) : A possible explanation for my riddle is that Sharif had an older version of some dependency when he built the front end in June. The package-lock.json file is not included in the git repo (because otherwisde we would also have to include the node_modules), but I hope that webpack somehow writes the ...
2 ans, 2 mois ago by Johana Amorin about #5239 (Document & test the React front end) (3 replies) : I Was busy working onpersonal project, I´ll catch up on this ticket this week.
2 ans, 2 mois ago by Luc Saffre about #5239 (Document & test the React front end) : I wrote a blog post about my latest riddle, on which i have been working the whole day yesterday: [url luc.lino-framework.org/blog/2024/0817.html]
2 ans, 2 mois ago by Luc Saffre about #5239 (Document & test the React front end) : The grid views didn't work because I had done "npm audit fix --force". I restored the state (checkout package.json, rm -r package-lock.json node_modules, npm install) and the grid views are back. But here is yet another riddle: the grid cell editor doesn't start in the version built on my machine.
2 ans, 2 mois ago by Luc Saffre about #5239 (Document & test the React front end) : OK it seems "npm run build" now obeys me more or less, and the "Pinned URL(s)" button is gone, but the front end is still partly broken: grid views don't work, the js console shows 2 error messages "TypeError: this.dataTable.getElement is not a function".
2 ans, 2 mois ago by Luc Saffre about #5239 (Document & test the React front end) (1 reply) : I commented out the Pinned URL(s) button and the renderURLPinsOverlay() method (changes in components/AppInlineProfile.jsx), which works as expected, but when I also commented out "export const PINNED_URL_STORE_KEY = "pinned-urls";" in constants.js, I get a warning "export 'PINNED_URL_STORE_KEY' (i...
2 ans, 2 mois ago by Luc Saffre about #5239 (Document & test the React front end) : I also watched the [url webpack.js.org/guides/asset-management/ Webpack asset management guide]. It's impressing how many plugins exist.
2 ans, 2 mois ago by Luc Saffre about #5239 (Document & test the React front end) : After almost a full week of interruption, today I finally continued my dive into Lino's React frontend: [url luc.lino-framework.org/blog/2024/0815.html]
2 ans, 2 mois ago by Luc Saffre about #5239 (Document & test the React front end) : I tried Zineb Elouarradi's suggestion for [url github.com/facebook/create-react-app/issues/13643], but that didn't change anything.
2 ans, 2 mois ago by Luc Saffre about #5239 (Document & test the React front end) : I wonder why "npm run build" also creates a file "dummy.json" in the root directory.
2 ans, 2 mois ago by Luc Saffre about #5239 (Document & test the React front end) : I finished for today and published my detailed work report on [url luc.lino-framework.org/blog/2024/0807.html].
2 ans, 2 mois ago by Johana Amorin about #5239 (Document & test the React front end) (1 reply) : Maybe you already did, but deleting the "node_modules" folder and "package-log.json" and then going back and installing npm dependencies with "npm install" fixes version conflicts if any. Now when I run "npm start" I get > lino_react@24.5.0 start > electron-forge start
✔ Checking the system. ✔ Locat...
2 ans, 2 mois ago by Johana Amorin about #5239 (Document & test the React front end) (1 reply) : What I will do is to study depth React, npm, Node.js, wbpack etc.. to work efficiently this issues, its good for you @luc to know some of this, but is not efective nor healthy for you to do everything. I will help as much as I can.
2 ans, 2 mois ago by Luc Saffre about #5239 (Document & test the React front end) : When I follow [url www.freecodecamp.org/news/npm-vs-npx-whats-the-difference/], the sandbox doesn't work, "npm start" says "Cannot find module 'ajv/dist/compile/codegen'".
2 ans, 2 mois ago by Luc Saffre about #5239 (Document & test the React front end) : I noticed only now that the correct spelling is "JavaScript" and not "Javascript". Replaced 115 occurrences in 95 files in 7 repositories.
2 ans, 2 mois ago by Luc Saffre about #5239 (Document & test the React front end) : Today I had a chat session with Tonis, who helped me to find the explanation. But when I tried to verify the solution, it didn't work any more. See [url luc.lino-framework.org/blog/2024/0806.html my blog]. My WTF at the end looks like the one Joy had some weeks ago when she was sure to have the issu...
2 ans, 2 mois ago by Luc Saffre about #5239 (Document & test the React front end) : I tried to grasp the problem from the roots: I read a series of basic introductions to React and JSX and wrote a [url luc.lino-framework.org/blog/2024/0805.html blog entry about it].
2 ans, 2 mois ago by Luc Saffre about #5239 (Document & test the React front end) (2 replies) : Joy and I had a Jitsi meeting, trying to get "npm run build" to work on my machine. We tried different versions of puppeteer (consulted the changelog). I changed header: "new" to header: false in two *.ts files (the trick that did it on Joy's machine, as it seemed). But no success yet.
2 ans, 2 mois ago by Johana Amorin about #5239 (Document & test the React front end) (3 replies) : When I ran "npm run build" I got an error in the files lino_react/react/components/__tests__/cloneUI.ts and lino_react/react/components/__tests__/integrity.ts the error was the same for both in the line "browser = await puppeteer.launch({headless: “new”});," it seems that this version of puppeter do...
2 ans, 2 mois ago by Luc Saffre about #5239 (Document & test the React front end) : I also worked on this today. I am still having errors in `npm run build`. Here is my blog: [url luc.lino-framework.org/blog/2024/0729.html].
2 ans, 2 mois ago by Johana Amorin about #5239 (Document & test the React front end) : I´m going to start working on this ticket
2 ans, 2 mois ago by Luc Saffre about #5239 (Document & test the React front end) : Here is a good getting started doc for me: [url nodesource.com/blog/the-basics-getting-started-with-npm/].
2 ans, 3 mois ago by Luc Saffre about #5239 (Document & test the React front end) : Today I continued to poke around and try to get "npm run build" to work on my machine. I am advancing, but not yet there. I wrote a report on my blog: [url luc.lino-framework.org/blog/2024/0720.html].
2 ans, 3 mois ago by Luc Saffre about #5239 (Document & test the React front end) : I am trying to run "npm run build". I got a bit further, bhut now it's saying "Module not found: Error: Can't resolve 'react-dom/client' in '/home/luc/work/react/lino_react/react/components'" and a series of other errors, ending with "22 errors have detailed information that is not shown. Use 'stats....
2 ans, 3 mois ago by Luc Saffre about #5239 (Document & test the React front end) : I reactivated the react sphinx docs at [url react.lino-framework.org/] (after commenting out sphinx_js extension, which has some problem).
2 ans, 10 mois ago by Sharif Mehedi about #5239 (Document & test the React front end) : We are now using puppeteer to emulate a browser. Which for the moment tests only the landing page and sign in as robin on noi. As we go along the test suite should grow bigger by the day. I will continue in a test driver manner in the future. And the first step to (the test driver manner) which will...
2 ans, 10 mois ago by Sharif Mehedi about #5239 (Document & test the React front end) : react community also suggests to use jest. see [url create-react-app.dev/docs/running-tests/ this page]
2 ans, 10 mois ago by Sharif Mehedi about #5239 (Document & test the React front end) : I am thinking about using the package [url jestjs.io/docs/tutorial-react jest] to test react
2 ans, 11 mois ago by Sharif Mehedi about #5239 (Document & test the React front end) : React sphinx build is passing now.
2 ans, 11 mois ago by Luc Saffre about #5239 (Document & test the React front end) : I just pushed a few changes trying to get sphinx-build to pass in react. No success yet. I saw that it is failing [url gitlab.com/lino-framework/react/-/jobs/5569044131] with Could not import extension sphinx_js (exception: No module named 'sphinx_js')
2 ans, 11 mois ago by Sharif Mehedi about #5239 (Document & test the React front end) : Created new Ticket #5239 (document react).