#5330 (upgrade react (mostly primereact))

by Sharif Mehedi · in Developers · assigned to Sharif Mehedi

Summary

Children

Comments

1 month, 4 weeks ago by Sharif Mehedi about #5330 (upgrade react (mostly primereact)) : I put the half done work into synodalsoft/reactnext.
1 month, 4 weeks ago by Sharif Mehedi about #5330 (upgrade react (mostly primereact)) : Quote from the license page: "A licensed developer may build an unlimited number of applications with the Software."
1 month, 4 weeks ago by Sharif Mehedi about #5330 (upgrade react (mostly primereact)) : The community license is per-developer (NOT per site), and Rumma & Ko does meet the eligibility requirements (see the license page). So, we can use primenext for multiple site using a single license key.
2 months ago by Sharif Mehedi about #5330 (upgrade react (mostly primereact)) : So, i am not locked
2 months ago by Sharif Mehedi about #5330 (upgrade react (mostly primereact)) : I've applied for a license and it gave me one immediately.
2 months ago by Sharif Mehedi about #5330 (upgrade react (mostly primereact)) : Ow no! I've hit a dead end. We need a license to use primereact (nothing won't render without a license). We need to try to acquire the Community license.
2 months ago by Luc Saffre in reply to Sharif Mehedi about #5330 (upgrade react (mostly primereact)) : I like "lino_primenext".
2 months ago by Sharif Mehedi about #5330 (upgrade react (mostly primereact)) (1 reply) : I am deciding on `lino_primenext`
2 months ago by Sharif Mehedi about #5330 (upgrade react (mostly primereact)) : Naming the primereact-v11 compat project, I am considering `lino_pr_v11` or just `lino_pr` or `lino_pr_next`. @luc what do you think?
2 months ago by Luc Saffre about #5330 (upgrade react (mostly primereact)) : We discovered together that PrimeReact is no longer free software. Excerpts from primeui.dev/nextchapter : PrimeUI is a unified licensing model for PrimeNG, PrimeReact, and PrimeVue the add-on model that once funded our work no longer matches the scale of what we maintain. Maintaining four major UI ...
2 months ago by Luc Saffre in reply to Sharif Mehedi about #5330 (upgrade react (mostly primereact)) : Let's look and discuss at this together.
2 months ago by Sharif Mehedi about #5330 (upgrade react (mostly primereact)) (1 reply) : It seems the latest DataTable features sorting and column filtering work on the client directly without making any database calls. Not sure if this is a good feature to have.
2 months ago by Luc Saffre about #5330 (upgrade react (mostly primereact)) : That sounds even more suspicious. We do have the data as an object, it's easy to simply send row2dict() instead of row2list(). We can have an attribute Renderer.send_table_rows_as_list.
2 months ago by Sharif Mehedi about #5330 (upgrade react (mostly primereact)) : I think I well keep the backend as it is, but have the frontend transform the row data into an object.
2 months ago by Sharif Mehedi about #5330 (upgrade react (mostly primereact)) : As I said, primereact expects objects as rows. Should I do a frontend helper to transform the result of row2list into javascript objects? If we consider the bandwidth, this feels more logical to do.
2 months ago by Luc Saffre about #5330 (upgrade react (mostly primereact)) : This sounds suspicious to me. The whole point of using row2list() instead of row2dict() is to use less bandwidth by not repeating the attribute names for each row. I have difficult to believe that the DataTable no longer supports this transferring tabular data without repeating the attribute names f...
2 months ago by Sharif Mehedi in reply to Luc Saffre about #5330 (upgrade react (mostly primereact)) : We'll need instead of pk_index, another actor attrubute, pk_field.
2 months ago by Sharif Mehedi in reply to Luc Saffre about #5330 (upgrade react (mostly primereact)) : From react views, in the ApiList.get, returning a list of rows using store.row2dict(row) should already let us make it compatible with the primereact datatable. There are certain other places where we will have to refrain from using store.row2list and use store.row2dict.
2 months ago by Luc Saffre in reply to Sharif Mehedi about #5330 (upgrade react (mostly primereact)) (2 replies) : Maybe the react render must define a <Record> for each actor?
2 months ago by Sharif Mehedi about #5330 (upgrade react (mostly primereact)) (1 reply) : New implementation of primereact DataTable expects data as "Record<string, unknown>[] | object[]", but our backend sends back the data as array of arrays. So the backend must now return the data as array of objects or we can transform the data in the frontend, which may not be an ideal or efficient ...
2 months ago by Sharif Mehedi about #5330 (upgrade react (mostly primereact)) : Primereact made the ContextMenu component a little complecated, it must wrap the quill container to work seemlessly, but this blocks us from using the regular browser's context menu (for example, to inspect). So far, I couldn't find a way to conditionally stop it from appearing and have the browser ...
2 months ago by Sharif Mehedi about #5330 (upgrade react (mostly primereact)) : Yesterday I started another direction of changes in react, concerning the typescript files, the type annotations for imported modules did not really have their types loaded into the compiler, they were all t.StringKeyedObject (s), which was bad proper type checking of the used modules. And this is g...
2 months ago by Sharif Mehedi about #5330 (upgrade react (mostly primereact)) : For the component that were in primereact-v10 and missing in primereact-v11, I started a new file where I'm creating those components for our use cases. The file name is "LinoComponentUnits.tsx" and it currently contains, "DropDown" using primereact's new feature component (PRNFC) "Select", "MultiSe...
2 months ago by Luc Saffre about #5330 (upgrade react (mostly primereact)) : Aw, sounds scary. Note that we have the React theme choice feature only for one customer (prima) during the test phase where they had a sandbox copy of their site, and right now they even do not use their sandbox and maybe they will never ask for it again. There will be no tears if that feature goes...
2 months, 1 week ago by Sharif Mehedi about #5330 (upgrade react (mostly primereact)) : The list of available public themes has only four variants of them. That huge list in react models goes away and become a very short list.
2 months, 1 week ago by Sharif Mehedi about #5330 (upgrade react (mostly primereact)) : Primereact does not provide the theme css as static files anymore instead the have it packaged into some modules. and it seems we need a redo of theme implementation.
2 months, 1 week ago by Sharif Mehedi about #5330 (upgrade react (mostly primereact)) : PrimeReact 11 seems to have come with a lot of differences compared to primereact 10. So, I will start my changes in a separate branch and only after getting confidence I will merge to master. These changes shell also contain react 19.
2 years, 9 months ago by Sharif Mehedi about #5330 (upgrade react (mostly primereact)) : Naah it's good. NOT buggy.
2 years, 9 months ago by Sharif Mehedi about #5330 (upgrade react (mostly primereact)) : Now that I think about it. It may still be buggy.
2 years, 9 months ago by Sharif Mehedi about #5330 (upgrade react (mostly primereact)) : I just fixed the open-in-own-window button on the slave panels.
2 years, 10 months ago by Sharif Mehedi about #5330 (upgrade react (mostly primereact)) : FileUpload is good back again.
2 years, 10 months ago by Sharif Mehedi about #5330 (upgrade react (mostly primereact)) : It seems we need to write a custom uploadHandler (we already had some override of primereact FileUpload.upload method, IMO, was not a good solution)
2 years, 10 months ago by Sharif Mehedi about #5330 (upgrade react (mostly primereact)) : I just pushed react git. Things may brake. Here's how my current TODO looks like: # fix GridElement.arrowSelect # fix GridElement.onRowDoubleClick # fix GridElement currentInputTabIndex # fix SplitButton value # test if FileUpload works
2 years, 10 months ago by Sharif Mehedi about #5330 (upgrade react (mostly primereact)) : I had to upgrade react (dependencies let to an upgrade require of primereact as well) to make jest work for the testing. Upgradation of primereact is going to give us some trouble, and react should be thoroughly tested again.
2 years, 10 months ago by Sharif Mehedi about #5330 (upgrade react (mostly primereact)) : Created new Ticket #5330 (upgrade react (mostly primereact)).