#5506 (Insert buttons are duplicated in slave summary)
40 · by Luc Saffre · in Developers · assigned to Sharif Mehedi
Kurzbeschreibung
Kinder
Kommentare
- 2 Jahre, 7 Monate ago von Luc Saffre about #5506 (Insert buttons are duplicated in slave summary) : I wrote the following doctest to verify it:
>>> from etgen.html import E, tostring >>> kwargs = dict(foo="bar") >>> tostring(E.a(**kwargs)) '<a foo="bar"/>' >>> tostring(E.a("", **kwargs)) '<a foo="bar"></a>' - 2 Jahre, 7 Monate ago von Luc Saffre about #5506 (Insert buttons are duplicated in slave summary) : Wow! That was a subtle one! Congratulations.
- 2 Jahre, 7 Monate ago von Sharif Mehedi about #5506 (Insert buttons are duplicated in slave summary) : see: [url gitlab.com/lino-framework/react/-/commit/fb713d7d34637e2c1aa6cc4ba0fbdecefb08de01 commit]
- 2 Jahre, 7 Monate ago von Sharif Mehedi about #5506 (Insert buttons are duplicated in slave summary) : It seems that in react setInnerHTMLDangerously has trouble rendering an "a" tag not having any text. Fixed it by putting a "" (empty string) in E.a("", **kwargs) in react.Renderer.clickable_link.
- 2 Jahre, 7 Monate ago von Sharif Mehedi about #5506 (Insert buttons are duplicated in slave summary) : Everything in request and response seems ok. I guess it's coming from the setInnerHTMLDangerously. NOT yet sure how to fix it.
- 2 Jahre, 7 Monate ago von Luc Saffre about #5506 (Insert buttons are duplicated in slave summary) : @8lurry I assign this to you because it seems to be caused by the JS code (occurs in noi1r but not in noi1e). Increased priority because we have it now in Jane (two (+) buttons in the Comments panel).
- 2 Jahre, 7 Monate ago von Luc Saffre about #5506 (Insert buttons are duplicated in slave summary) : A strange side effect of my local changes...
- 2 Jahre, 7 Monate ago von Luc Saffre about #5506 (Insert buttons are duplicated in slave summary) : Created new Ticket #5506@dev (Insert buttons are duplicated in slave summary).