by Luc Saffre · in Developers · assigned to Luc Saffre

Summary

Children

Comments

• 2 years, 7 months ago by Luc Saffre about #5520 (Recent comments shows comments to tickets that the user cannot see) : I pushed my latest changes. And I will close this ticket now. Of course I am not yet satisfied with the documentation, but at least the page [url dev.lino-framework.org/dev/querysets.html Customizing your querysets] has become better...
• 2 years, 7 months ago by Luc Saffre about #5520 (Recent comments shows comments to tickets that the user cannot see) : I now also removed the Actor.request_queryset() method, i.e. leaving only get_request_queryset(). Added/reviewed two doctest cases in welfare docs to verify that the tables (reception.ExpectedGuests and cal.EventsByClient) still has the same results.
• 2 years, 7 months ago by Luc Saffre about #5520 (Recent comments shows comments to tickets that the user cannot see) : I pushed a series of changes around get_request_queryset(). The documentation is still not finished because I want to simplify things even more. This is an intermediate step because test suites are passing.
• 2 years, 7 months ago by Luc Saffre about #5520 (Recent comments shows comments to tickets that the user cannot see) : I started writing documentation about this, and this is going to bring more optimizations.
• 2 years, 7 months ago by Luc Saffre about #5520 (Recent comments shows comments to tickets that the user cannot see) : I pushed my work (in lino, xl, noi, book, ,,,)
• 2 years, 7 months ago by Luc Saffre about #5520 (Recent comments shows comments to tickets that the user cannot see) : OMG! More than 8 hours I was locked with this. Explanation was: I was testing on the public demo site and not on localhost.
• 2 years, 7 months ago by Luc Saffre about #5520 (Recent comments shows comments to tickets that the user cannot see) : The test suite passes and everything looks great... I was about to push my changes.... and then I noticed that the original problem still exists :-/
• 2 years, 7 months ago by Luc Saffre about #5520 (Recent comments shows comments to tickets that the user cannot see) : I fixed the last test cases in book (hopefully). TODO: do we need more coverage?
• 2 years, 7 months ago by Luc Saffre about #5520 (Recent comments shows comments to tickets that the user cannot see) : Still fiddling with getting the test suite pass after my changes. TIL that when qs = Ticket.objects.none(), qs.query exists and is a django.db.models.sql.Query object, but when you try to print it, Django raises an exception EmptyResultSet
• 2 years, 7 months ago by Luc Saffre about #5520 (Recent comments shows comments to tickets that the user cannot see) : The whole system regarding visibility of comments was poorly designed. I replaced get_comments_filter() by add_user_filter() and plan to write test cases in order to check whether the new design is better.
• 2 years, 7 months ago by Luc Saffre about #5520 (Recent comments shows comments to tickets that the user cannot see) : For example sign in as marc in noi1r and the first comment you see is "by robin in reply to rolf about #106 (How can I see where bar?)", but clicking on 106 gives a 404 error.
• 2 years, 7 months ago by Luc Saffre about #5520 (Recent comments shows comments to tickets that the user cannot see) : Created new Ticket #5520 (Recent comments shows comments to tickets that the user cannot see).