by Luc Saffre · in Developers · assigned to Luc Saffre

Kokkuvõte

Children

Kommentaarid

• 2 aastat ago by Luc Saffre about #5766 (Non-admin users in Noi can't comment on a ticket) : Jane is back after the upgrade.
• 2 aastat ago by Luc Saffre about #5766 (Non-admin users in Noi can't comment on a ticket) : I'll now release to Jane for this ticket.
• 2 aastat ago by Luc Saffre about #5766 (Non-admin users in Noi can't comment on a ticket) : Another aspect of this ticket is that user type Developer in Noi should be permitted to modify tickets of other users. I fixed this by adding manager_roles_required = dd.login_required(TicketsStaff) to the Ticket model.
• 2 aastat ago by Luc Saffre about #5766 (Non-admin users in Noi can't comment on a ticket) : I "fix" this by removing the add_comment field. The current implementation is too quirky. I rather imagine a new concept of "embedded insert forms" with its own submit button for adding a comment from the detail of a ticket.
• 2 aastat ago by Luc Saffre about #5766 (Non-admin users in Noi can't comment on a ticket) (1 reply) : Ha! It is because of the option alwaysEditable. When this option is true, TextFieldElement doesn't even ask disable_editing.
• 2 aastat ago by Luc Saffre about #5766 (Non-admin users in Noi can't comment on a ticket) : Yes, the problem is that add_comment agrees to start editing on click when the whole row is read-only. The description field is also a TextField and does not start editing when you click on it.
• 2 aastat ago by Luc Saffre about #5766 (Non-admin users in Noi can't comment on a ticket) : It's correct that mathieu may not edit other people's tickets. BTW the + button in the comments panel does work and lets mathieu comment on the ticket. Yes, the AddCommentField doesn't work when the user has no permission to edit the ticket because Lino currently doesn't realize that PUTting only to...
• 2 aastat ago by Luc Saffre about #5766 (Non-admin users in Noi can't comment on a ticket) : Sign in as mathieu in noi1r, open a ticket detail, write "Hello" into the Add comment field, hit Ctrl+S. Lino says django.core.exceptions.PermissionDenied: No permission to run TableRequest Save on tickets.MyTicketsToWork
  
• 2 aastat ago by Luc Saffre about #5766 (Non-admin users in Noi can't comment on a ticket) : Created new Ticket #5766 (Non-admin users in Noi can't write comment on a ticket).