by Luc Saffre · in Developers · assigned to Luc Saffre

Kokkuvõte

Children

Kommentaarid

• 1 aasta, 9 kuud ago by Luc Saffre about #5877 (Inserting an image into a comment can break the general page layout) : Jane is back after the upgrade and the issue is gone :-) Of course I also had to run "pm checkdata -f memo.PreviewableChecker" to rebuild the previews of the bodies.
• 1 aasta, 9 kuud ago by Luc Saffre about #5877 (Inserting an image into a comment can break the general page layout) : I published my changes and made releases to PyPI for rstgen, noi, amici, lino, xl, react. Soon I will also upgrade Jane and Froinde.
• 1 aasta, 9 kuud ago by Luc Saffre about #5877 (Inserting an image into a comment can break the general page layout) : But before publishing my work, I must adapt the test suite, which will have failures because I added demo data.
• 1 aasta, 9 kuud ago by Luc Saffre about #5877 (Inserting an image into a comment can break the general page layout) : Cool! I think a got this fixed. The parse_image_spec() function must use max-width and max-height instead of width and height.
• 1 aasta, 9 kuud ago by Luc Saffre about #5877 (Inserting an image into a comment can break the general page layout) : I added a screenshot to the DEMO_DATA in book and reorganized the demo fixtures so that we have an example for reproducing this issue in the noi1r demo site.
• 1 aasta, 9 kuud ago by Luc Saffre about #5877 (Inserting an image into a comment can break the general page layout) : For example the following image causes the Comments panel to become wider than usual (I am not sure whether this is wrong) and then still doesn't fit into the borders of the panel.
  [ERROR Invalid image format 'tiny' in '[file 76 tiny|]' at position 187-202]
• 1 aasta, 9 kuud ago by Luc Saffre about #5877 (Inserting an image into a comment can break the general page layout) : Created new Ticket #5877 (Inserting an image into a comment can break the general page layout).