#5918 (Plugin.needs_plugins should not automatically install needed plugins)

by Luc Saffre · in Developers · assigned to Luc Saffre

Kurzbeschreibung

Installing them automatically can make it difficult to understand why some plugin is being loaded before or after some other plugin. The loading order of plugins is important for loading demo fixtures and for building the application menu. Explicit is better than automatic. Rather than loading them automatically, needs_plugins would just raise an exception when a needed plugin is missing. Alternative to explore: what if we would load needed_plugins at the end?

Kinder

Kommentare

1 Jahr, 8 Monate ago von Luc Saffre about #5918 (Plugin.needs_plugins should not automatically install needed plugins) : Okay, I give up my idea: Things aren't as bad as i thought when I submitted this ticket. Installing required plugins at the end (or not installing them at all) is not a solution for the avalanche of silly changes I had for #5917 (Clicking on the img rendered by file memo command doesn't show the image). So I mark the present ticket as refused.
1 Jahr, 8 Monate ago von Luc Saffre about #5918 (Plugin.needs_plugins should not automatically install needed plugins) : And another surprise: the vat plugin requires the accounting plugin and in its ui.py module it does "from lino_xl.lib.accounting.models import Voucher", so accounting must indeed get installed before vat.
1 Jahr, 8 Monate ago von Luc Saffre about #5918 (Plugin.needs_plugins should not automatically install needed plugins) : So I implemented the new rule: required plugins are loaded at the end, when all requested plugins have been installed. One surprise:
SystemCheckError: System check identified some issues: ERRORS: ?: (daphne.E001) Daphne must be listed before django.contrib.staticfiles in INSTALLED_APPS.
1 Jahr, 8 Monate ago von Luc Saffre about #5918 (Plugin.needs_plugins should not automatically install needed plugins) : I am doing it now because anyway I have changes in menu ordering caused by #5917 (Clicking on the img rendered by file memo command doesn't show the image).
1 Jahr, 8 Monate ago von Luc Saffre about #5918 (Plugin.needs_plugins should not automatically install needed plugins) : No need to hurry. It think it would make Lino easier and more clear. But I'm not 100% sure and it would mean a lot of work.
1 Jahr, 8 Monate ago von Luc Saffre about #5918 (Plugin.needs_plugins should not automatically install needed plugins) : Created new Ticket #5918 (Plugin.needs_plugins should not automatically install needed plugins).