◄ ► | Muuda | Home | Admin | en de fr et | Sign in

#6482 (Add a SubscribeToList action in noi2)

by Luc Saffre · in Developers · assigned to Luc Saffre

Kokkuvõte

Similar to the "Or register as a new user." action. It should appear somewhere (in the footer?) automaticaly when both plugins contacts and lists are installed. It would ask for three fields: first_name, last_name and email and then create at least two database rows: a contacts.Person and one or several lists.Member rows. Add a new checkbox field listsl.List.default_for_new_users. New users would automatically get subscribed to all lists having this True.

As a side effect, the lists plugin no longer makes lists of partners but lists of users. In amici we therefore use topics instead of lists, and in avanti we removed the lists plugin because anyway it wasn't being used in production.

Children

Kommentaarid

  • 7 kuud ago by Luc Saffre about #6482 (Add a SubscribeToList action in noi2) : Aha, yes, so the execute_webform() method was missing on the WebForm mixin? So you fixed this issue before I even noticed it :-) And I then continued, I moved the call to mark_done() from execute_webform() because I now set mark_done() in the execute_webforms procedure. Because I had a next issue : ...
  • 7 kuud ago by Sharif Mehedi in reply to Sharif Mehedi about #6482 (Add a SubscribeToList action in noi2) : I put a fix to this, a fallback execute_webform on WebForm mixin.
  • 7 kuud ago by Luc Saffre in reply to Sharif Mehedi about #6482 (Add a SubscribeToList action in noi2) : Oops I see this only now. Maybe it was fixed as a side effect with my recent changes. Is this issue still there?
  • 7 kuud ago by Luc Saffre about #6482 (Add a SubscribeToList action in noi2) : I pushed a (hopefully) last series of changes to lino, ug, xl, book, vedi, amici.
  • 7 kuud ago by Luc Saffre in reply to Luc Saffre about #6482 (Add a SubscribeToList action in noi2) : To fix this, I renamed the module from "parser" to "utils". The issue arose only now because I had reviewed and modernized the Sphinx docs.
  • 7 kuud ago by Luc Saffre about #6482 (Add a SubscribeToList action in noi2) (1 reply) : A last silly problem during builddocs: the name "lino.modlib.memo.parser" can either refer to the corresponding module or to the plugin attribute.
  • 7 kuud ago by Luc Saffre about #6482 (Add a SubscribeToList action in noi2) : todo: combo box for selecting which newsletter doesn't work on publisher
  • 7 kuud ago by Luc Saffre about #6482 (Add a SubscribeToList action in noi2) : Hey, I discovered only now that we don't need a field SiteConfig.newsletter_list for configuring the default value of the subscribe webform. We have the List.default_for_new_users checkbox. That means another "inv prep test" before pushing my changes.
  • 7 kuud ago by Luc Saffre in reply to Luc Saffre about #6482 (Add a SubscribeToList action in noi2) : An important side-effect change is that the default value for lino.modlib.memo.primary_front_end is now kernel.primary_front_end and no longer kernel.editing_front_end. We want the <a> generated by a memo command ref to href to that database using the publisher front end if that model has a publish...
  • 7 kuud ago by Luc Saffre about #6482 (Add a SubscribeToList action in noi2) (1 reply) : I extended the manual testing suite and found a few more bugs and optimizations.
  • 7 kuud ago by Luc Saffre about #6482 (Add a SubscribeToList action in noi2) : The test suite passed and I pushed my changes in multiple repositories.
  • 7 kuud ago by Luc Saffre about #6482 (Add a SubscribeToList action in noi2) : todo: define get_row_by_pk() on model? Because locally right now I'm saying "obj = m.get_default_table().get_row_by_pk(ar, pk)"
  • 7 kuud ago by Sharif Mehedi about #6482 (Add a SubscribeToList action in noi2) : I removed the webforms plugin from pronto and fell back to modlib.webforms.
  • 7 kuud ago by Sharif Mehedi about #6482 (Add a SubscribeToList action in noi2) : Should we have a default execute_webform method on WebForm mixin which will simply call mark_done, so that things doesn't break.
  • 7 kuud ago by Sharif Mehedi about #6482 (Add a SubscribeToList action in noi2) (2 replies) : The call to WebForm.execute_webform(ar) will fail when there's a webform of anything other then CreateUserRequest, i.e. a ContactRequest, which doesn't have a execute_webform method, so the execute_webforms schedule will always get disabled when there's a webform in the database that is not a Create...
  • 7 kuud ago by Sharif Mehedi in reply to Luc Saffre about #6482 (Add a SubscribeToList action in noi2) : I will remove it, with some plugin setting dependent validation in full_clean and come custom user facing messages.
  • 7 kuud ago by Luc Saffre about #6482 (Add a SubscribeToList action in noi2) : todo: add a link to the Subscribe page to the footer.
  • 7 kuud ago by Luc Saffre about #6482 (Add a SubscribeToList action in noi2) : I now pushed my changes in multiple repositories.
  • 7 kuud ago by Luc Saffre about #6482 (Add a SubscribeToList action in noi2) (1 reply) : My changes include replacing the create_users() system task by execute_webforms() and a execute_webform method on the WebForm mixin. This causes a failure in pronto/lino_pronto/lib/webforms/models.py, which (AFAICS) anyway can disappear now. @8lurry please let's talk if you disagree.
  • 7 kuud ago by Luc Saffre about #6482 (Add a SubscribeToList action in noi2) : Together on jitsi, Sharif and i converted the SubscribeToList actuon to a webform. Afterwards i continued alone to adapt the test suite.
  • 10 kuud, 2 nädalat ago by Luc Saffre in reply to Sharif Mehedi about #6482 (Add a SubscribeToList action in noi2) : The SubscribeToList and RegisterUSer actions are actually quite similar. Maybe we should even combine them.
  • 10 kuud, 2 nädalat ago by Luc Saffre about #6482 (Add a SubscribeToList action in noi2) : How to protect the Lino site against a robot creating a million of subscribers?
  • 10 kuud, 2 nädalat ago by Sharif Mehedi in reply to Luc Saffre about #6482 (Add a SubscribeToList action in noi2) (1 reply) : Meanwhile, in xl lists.SubscribeToList, I updated the run_from_ui chunk, so that when anonymous users subscribes, a new user is created and this new user is then passed to an sar which then passed to the save_new_instance method.
  • 10 kuud, 2 nädalat ago by Luc Saffre in reply to Luc Saffre about #6482 (Add a SubscribeToList action in noi2) : I fixed this problem. UserAuthored.on_create() now supports being called by an action request of anonymous.
  • 10 kuud, 2 nädalat ago by Luc Saffre about #6482 (Add a SubscribeToList action in noi2) (2 replies) : I tried it on immo1.mylino.net and when i am anonymous, I get the follolwing error message after submitting: dets 09 04:58:15 nora immo1[2108111]: Error during kernel.run_action() in ActionRequest for SubscribeToList on lists.NewsletterList: Cannot assign "<SimpleLazyObject: <lino.core.auth.utils.An...
  • 11 kuud ago by Sharif Mehedi about #6482 (Add a SubscribeToList action in noi2) : I just published the related changes in lino, xl, react and book.
  • 11 kuud ago by Sharif Mehedi about #6482 (Add a SubscribeToList action in noi2) : To create Membership on list with default_for_new_users set to true. User creation should also trigger a Partner creation if not given. Partner is required for lists.Member instances.
  • 11 kuud, 1 nädal ago by Luc Saffre about #6482 (Add a SubscribeToList action in noi2) : Created new Ticket #6482 (Add a SubscribeToList action in noi2).