#6811 (Change Ticket field names "summary" and "description" in Noi)
by Luc Saffre · in Developers · assigned to Jan Markus Kähara
Kurzbeschreibung
In the Ticket model, rename "Summary" to "Title" and "Description" to "Summary". To be future proof, we would like to rename also the internal field names. And while we are there, let's use the Previewable plugin.
Here is a mention: #135 (Inbox (complex work in reaction to incoming events)). This kind of references didn't create a memo.Mention row until now, but after this change it will.
Kinder
Kommentare
- 4 Monate, 1 Woche ago von Sharif Mehedi about #6811 (Change Ticket field names "summary" and "description" in Noi) : React test suite is clean again.
- 4 Monate, 1 Woche ago von Sharif Mehedi about #6811 (Change Ticket field names "summary" and "description" in Noi) : I will now update the react test suite to account for the new field names.
- 4 Monate, 2 Wochen ago von Luc Saffre about #6811 (Change Ticket field names "summary" and "description" in Noi) : I reviewed the changelog and the docs, with JMK watching. I talked a lot. We found two new issues: #6865 (The Open Help Window button doesn't work in Jane) and #6866 (Help texts taken help_texts.py aren't getting translated)
- 4 Monate, 2 Wochen ago von Luc Saffre about #6811 (Change Ticket field names "summary" and "description" in Noi) : I merged JMK's changes in the four repositories and pulled them to my machine. I wrote a note in the changelog. TODO: finish the changelog entry with JMK, then upgrade jane (including data migration with a manual change in the restore.py).
- 4 Monate, 2 Wochen ago von Luc Saffre about #6811 (Change Ticket field names "summary" and "description" in Noi) : Here is a document to read for you (@JMK): dev.lino-framework.org/utils/dbhash.html
- 4 Monate, 2 Wochen ago von Luc Saffre about #6811 (Change Ticket field names "summary" and "description" in Noi) : I helped @JMK to eliminate the last few test failures. Now he's running "pp inv prep test" a last time (to confirm that we didn't forget anything). Next step will be to push his changes and to write pull requests (in xl and book, and maybe lino and noi).
- 4 Monate, 2 Wochen ago von Luc Saffre about #6811 (Change Ticket field names "summary" and "description" in Noi) : In docs/dev/admin_main.rst there is a snippet that fails when Jan uses Fill Paragraph in PyCharm, although NORMALIZE_WHITESPACE is set. Strange.
- 4 Monate, 2 Wochen ago von Luc Saffre about #6811 (Change Ticket field names "summary" and "description" in Noi) : We also discovered #6862 (Did you run `apt-get install fluidsynth`? doesn't come when needed). Another way to refer to something is this: #6862.
- 4 Monate, 2 Wochen ago von Luc Saffre about #6811 (Change Ticket field names "summary" and "description" in Noi) : The book test suite had 17 failures after these changes. Together we started to process them one by one. We got 4..5 done and then Jan felt able to continue alone. Enjoy! No need to rush. Take your time to understand things. If you find something you don't understand, then ask for help (ideally by w...
- 4 Monate, 2 Wochen ago von Jan Markus Kähara about #6811 (Change Ticket field names "summary" and "description" in Noi) : Got done with everything and the noi1e prep worked. But when I went to do the pm prep and test for the book repo, it said in the terminal that the manage.py of the repo is missing so it cannot be done. Need help with this :)
- 4 Monate, 2 Wochen ago von Luc Saffre about #6811 (Change Ticket field names "summary" and "description" in Noi) : Before starting, you must make a fork of xl and noi repositories.
- 4 Monate, 2 Wochen ago von Luc Saffre about #6811 (Change Ticket field names "summary" and "description" in Noi) : Files to change:
/home/luc/work/noi/lino_noi/lib/tickets/models.py (TicketDetail) /home/luc/work/xl/lino_xl/lib/tickets/models.py (Ticket must also inherit from memo.Previewable and publisher.TitledPublishable, and then remove the fields "summary" and "description" that were defined on the Ticket) /... - 5 Monate ago von Luc Saffre Antwort auf Jan Markus Kähara about #6811 (Change Ticket field names "summary" and "description" in Noi) : See Comment #20922.
- 5 Monate ago von Jan Markus Kähara about #6811 (Change Ticket field names "summary" and "description" in Noi) (1 Antwort) : Right now I tried to follow my notes to find the parts I had to change and so on. But the mixin previwable I had to import. In my notes I had it as Titled.previewable. But right now I can't find it in (lino->lino->modlib->memo->mixins.py). Did I get the name of the previewable wrong or am I in the w...
- 5 Monate, 1 Woche ago von Luc Saffre about #6811 (Change Ticket field names "summary" and "description" in Noi) : Created new Ticket #6811 (Change Ticket field names "summary" and "description" in Noi).