#7029 (Find a better name for endswith('.json'))
by Luc Saffre · in Developers · assigned to Luc Saffre
Kokkuvõte
Children
Kommentaarid
- 3 nädalat, 3 päeva ago by Luc Saffre about #7029 (Find a better name for endswith('.json')) : I pushed "Rename camera_stream to capture_image and define it only when react is installed." in lino, book, welfare and pronto.
- 3 nädalat, 3 päeva ago by Luc Saffre in reply to Luc Saffre about #7029 (Find a better name for endswith('.json')) : I renamed CameraStream to CaptureImage, and now the Upload model defines the action only when react is installed, so no need to disable it later:
if dd.is_installed("react"): capture_image = CaptureImage()
We'll talk again about this when vuejs has an implementation for capture_image. - 3 nädalat, 3 päeva ago by Luc Saffre in reply to Luc Saffre about #7029 (Find a better name for endswith('.json')) : Did I get it right that the CameraStream action requires a preprocessor "Lino.captureImage", and currently such a preprocessor exists only in react? But we will also have one under VueJS? I'm thinking that we should define the action only when it makes sense, IOW on a site without react it shouldn't ...
- 3 nädalat, 3 päeva ago by Luc Saffre about #7029 (Find a better name for endswith('.json')) (2 replies) : There is currently a related doctest failure in welfare:
Differences (unified diff with -expected +actual): @@ -1,6 +1,5 @@ {'base_params': {'mk': 25, 'mt': 54, 'type_id': 1}, 'data_record': {'data': {'description': '', - 'disabled_fields': {'camera_stream... - 3 nädalat, 3 päeva ago by Luc Saffre about #7029 (Find a better name for endswith('.json')) : The test suite is at 70% and still green... I now pushed my changes (in lino, react and vuejs).
- 3 nädalat, 3 päeva ago by Luc Saffre about #7029 (Find a better name for endswith('.json')) : I added a new attribute uses_json_cache on the Renderer class. I'm running the test suite before pushing this.
- 3 nädalat, 3 päeva ago by Luc Saffre about #7029 (Find a better name for endswith('.json')) : Created new Ticket #7029 (Find a better name for endswith('.json')).