by Luc Saffre · in Developers · assigned to tonis

Summary

Children

Comments

• 6 years, 7 months ago by tonis about #3531 (Cannot select a city in froinde) : Fixed. Also fixed one bug where react crashed after trying to edit the site field in a tickets table that was caused by Hamza's code for making bool fields work in grid nicely. @khchine5 you didn't access the cell props right
  Going to commit and push my changes now.
• 6 years, 7 months ago by tonis about #3531 (Cannot select a city in froinde) : After hitting my head against the issues I see that the fix we figured with Hamza is actually correct. However it caused the bug to happen with slave tables, as the original reasok mk was set to pk, was the mk passed into lino layout, was mainly used for slavetables, and then it was looking at a wro...
• 6 years, 7 months ago by tonis about #3531 (Cannot select a city in froinde) : did a revert of commit 77f4c1aa24f13381d5b016e44f91d959000a31cf And the broken slave tables are sending a MK now, I think I need to look deeper into this issue. Going to reopen this ticket.
• 6 years, 7 months ago by tonis about #3531 (Cannot select a city in froinde) : I have a feeling that this fix has caused the issue that now the slave table for chat group members is broken...
• 6 years, 7 months ago by Luc Saffre about #3531 (Cannot select a city in froinde) : Thanks. Fixed. But there is a new issue introduced with the latest release. I'll create a ticket for it.
• 6 years, 7 months ago by khchine5 about #3531 (Cannot select a city in froinde) : React release is done and the froinde site upgraded.
• 6 years, 7 months ago by Luc Saffre about #3531 (Cannot select a city in froinde) : I added you.
• 6 years, 7 months ago by khchine5 about #3531 (Cannot select a city in froinde) : Ops I can't make the release to pypi because its maintained just by Luc. @Luc ,please add my as a maintainer
• 6 years, 7 months ago by tonis about #3531 (Cannot select a city in froinde) : Sounds about right... Perhaps this is a sign we need to make some e2e tests for all components.
• 6 years, 7 months ago by khchine5 about #3531 (Cannot select a city in froinde) : Commit a fix. Please try it. For the component LinoLayout I replaced the mk with the parent mk and add pk of the current record.
• 6 years, 7 months ago by khchine5 about #3531 (Cannot select a city in froinde) : I found that the mk is wrongly set when creating the details view using the LinoLayout component. It seems that is fixed , I still testing other cases.
• 6 years, 7 months ago by tonis about #3531 (Cannot select a city in froinde) : OK, so it's taking the url value before the prop value I guess
• 6 years, 7 months ago by khchine5 about #3531 (Cannot select a city in froinde) : YEs I just tested now and it works.
• 6 years, 7 months ago by tonis about #3531 (Cannot select a city in froinde) : If you edit and reseothe request with the correct pk, does it work?
  
• 6 years, 7 months ago by khchine5 about #3531 (Cannot select a city in froinde) : No the partner pk is 113 7 is the pk of the addresse/addressesbypartner For react the url of the browser is 127.0.0.1:8000/#/api/addresses/AddressesByPartner/7?mk=113&;mt=10
• 6 years, 7 months ago by tonis in reply to khchine5 about #3531 (Cannot select a city in froinde) : Idk about you, but it makes sense to me that it should be asking for the choice based on the slave table actor... As that's where you're asking... Would be good if we could get lino to work with both actor requests.
  The mk7, is that right? As in the partner had a pk of 7?
• 6 years, 7 months ago by khchine5 about #3531 (Cannot select a city in froinde) (1 reply) : The react url is : 127.0.0.1:8000/choices/addresses/AddressesByPartner/city?country=BE&;mk=7&mt=40&query=&start=0
  The extjs url is : 127.0.0.1:8000/choices/addresses/Addresses/city?_dc=1583228736534&;start=0&limit=20&country=BE®ion=&query=
• 6 years, 7 months ago by khchine5 about #3531 (Cannot select a city in froinde) : This seems that doesn't just for the city field. This occurs for any comobox field defined on a slave table. For some reason the fetched url is different then what we have with a compbox of a master table. We found the same difference with Extjs