by Luc Saffre · in Developers · assigned to Luc Saffre

Summary

Children

Comments

• 4 years, 10 months ago by Luc Saffre about #4338 (Noi doesn't notify all team members) : Yes, Sharif found the reason. There was some old code to avoid having multiple notifications about a same ticket.
• 4 years, 11 months ago by Sharif Mehedi about #4338 (Noi doesn't notify all team members) : This is the only line of code that I can blame for this: gitlab.com/lino-framework/lino/-/blob/master/lino/modlib/notify/models.py#L200
• 4 years, 11 months ago by Luc Saffre about #4338 (Noi doesn't notify all team members) : I added a log.info() call and we should look at the results on Jane after next release.
• 4 years, 11 months ago by Sharif Mehedi about #4338 (Noi doesn't notify all team members) : (Test) See if I get a notification.
• 4 years, 11 months ago by Luc Saffre about #4338 (Noi doesn't notify all team members) : Just for testing.
• 5 years ago by Luc Saffre about #4338 (Noi doesn't notify all team members) : I maybe found at least one problem: there was an obsolete condition in noi.tickets.Site.get_change_observers()
• 5 years, 1 month ago by Luc Saffre about #4338 (Noi doesn't notify all team members) : There is some hope that removing votes will automatically fix the issue of Jane not notifying everybody.
• 5 years, 1 month ago by Luc Saffre about #4338 (Noi doesn't notify all team members) : We decided to remove the votes plugin again from noi and to write a new plugin "nicknames" instead. In Noi we don't want a little star, we just want an editable virtual field "nickname" on every ticket, which shows the user's personal nickname for it.
• 5 years, 1 month ago by Luc Saffre about #4338 (Noi doesn't notify all team members) : There is a fundamental design issue here: votes were originally meant to mean "i want to get notified about changes on this ticket". But this meaning is actually not needed in Noi because this is regulated by the team. You simply get notified by changes in every ticket of your team, and this system ...
• 5 years, 1 month ago by Luc Saffre in reply to Luc Saffre about #4338 (Noi doesn't notify all team members) : This was the reason why Jane currently automatically starts a ticket after creating it.
• 5 years, 1 month ago by Luc Saffre about #4338 (Noi doesn't notify all team members) (1 reply) : En passant I reviewed Votable.set_author_votes() : when use_candidatures is False, it must must simply not call get_vote_raters() at all.
• 5 years, 1 month ago by Luc Saffre about #4338 (Noi doesn't notify all team members) : I guess that lino_noi.lib.tickets.Site.get_change_observers() is wrong. The line "subs = rt.models.groups.Group.objects.filter(site=ar.selected_rows[-1].site)" is nonsense, it should be "subs = rt.models.groups.Group.objects.filter(site=self)". To be meditated.
• 5 years, 1 month ago by Luc Saffre about #4338 (Noi doesn't notify all team members) : Jane sometimes sends notification email when a comment has been posted. But not to everybody. I guess that something went wrong when adding the votes plugin.I will check this.