by Luc Saffre · in Developers · assigned to Sharif Mehedi

Summary

Children

Comments

• 3 years, 6 months ago by Sharif Mehedi about #4894 (Email notification "[jane] {user} modified {what}" escapes html tags) : I did some changes in lino and book. please pull my changes.
• 3 years, 6 months ago by Sharif Mehedi about #4894 (Email notification "[jane] {user} modified {what}" escapes html tags) : What we have in eric is covered by noi1e. I think we can through it away completely.
• 3 years, 6 months ago by Sharif Mehedi about #4894 (Email notification "[jane] {user} modified {what}" escapes html tags) : I am not entirely sure about this behavior. Sometimes the anchor (a) tag has no href at all. Wondering why!
• 3 years, 6 months ago by Luc Saffre about #4894 (Email notification "[jane] {user} modified {what}" escapes html tags) : Yes, I think we should remove the eric project (after having moved all relevant test coverage to noi1r).
• 3 years, 6 months ago by Sharif Mehedi about #4894 (Email notification "[jane] {user} modified {what}" escapes html tags) : I wrote a test case on eric.tests.test_notify, and copied everything from noi1e.tests.test_notify and changed it to my will. I am wondering this test case may as well be on noi1e.tests.test_notify.
• 3 years, 6 months ago by Luc Saffre about #4894 (Email notification "[jane] {user} modified {what}" escapes html tags) : lino_riche and the eric project was made by @tonis, and I don't remember what it was about. We should remove the dependency from lino_riche because it is not maintained.
• 3 years, 6 months ago by Sharif Mehedi about #4894 (Email notification "[jane] {user} modified {what}" escapes html tags) : eric fails even with noi.
• 3 years, 6 months ago by Sharif Mehedi about #4894 (Email notification "[jane] {user} modified {what}" escapes html tags) : For now I will just make eric import from noi.
• 3 years, 6 months ago by Sharif Mehedi about #4894 (Email notification "[jane] {user} modified {what}" escapes html tags) : riche is broken. Should I try to fix it?
• 3 years, 6 months ago by Sharif Mehedi about #4894 (Email notification "[jane] {user} modified {what}" escapes html tags) : looks like lino_riche was written on python2.
• 3 years, 6 months ago by Sharif Mehedi about #4894 (Email notification "[jane] {user} modified {what}" escapes html tags) : what is lino_riche?
• 3 years, 7 months ago by Luc Saffre about #4894 (Email notification "[jane] {user} modified {what}" escapes html tags) (1 reply) : Did you work already on this, @8lurry ?
• 3 years, 7 months ago by Luc Saffre about #4894 (Email notification "[jane] {user} modified {what}" escapes html tags) : I guess that we can extend book/lino_book/projects/eric/tests/test_notify.py to reproduce it.
• 3 years, 7 months ago by Luc Saffre about #4894 (Email notification "[jane] {user} modified {what}" escapes html tags) : The bug itself is some silly change to do, but we should use this bug to increase our coverage: first write a test that reproduces the bug, and only then fix it.
• 3 years, 7 months ago by Luc Saffre about #4894 (Email notification "[jane] {user} modified {what}" escapes html tags) : Created new Ticket #4894 (Email notification "[jane] {user} modified {what}" escapes html tags).