by Luc Saffre · in Developers · assigned to Sharif Mehedi

Summary

Children

Comments

• 2 years, 8 months ago by Luc Saffre about #5440 (Changing the ticket of a comment doesn't work. Causes an almost-blank page.) : I adapted the doctests in book that were broken because we now comment on the tickets in reversed order.
• 2 years, 8 months ago by Luc Saffre about #5440 (Changing the ticket of a comment doesn't work. Causes an almost-blank page.) : I added a doctest snippet to cover this issue. TODO: My change probably breaks some tests because I inverted the sorting order of Commentables (because we needed a comment on a ticket with pk > 110)..
• 2 years, 8 months ago by Sharif Mehedi about #5440 (Changing the ticket of a comment doesn't work. Causes an almost-blank page.) : Fixed. See: [url gitlab.com/lino-framework/lino/-/commit/9c06c90f285e78df7041f45e7e58f5299ab5c867 changes]
• 2 years, 8 months ago by Luc Saffre about #5440 (Changing the ticket of a comment doesn't work. Causes an almost-blank page.) : I think that the bug is in lino_react/react/views.py line 276 where it creates a programmatical ActionRequest using the incoming Django request ("rpt.request(request=request)").
• 2 years, 8 months ago by Luc Saffre about #5440 (Changing the ticket of a comment doesn't work. Causes an almost-blank page.) : No need to change the number of demo tickets from 100 to 200 in lino_noi/lib/noi/fixtures/demo.py because noi1r actually has 116 tickets (16 are made by some opther fixture).
• 2 years, 8 months ago by Sharif Mehedi about #5440 (Changing the ticket of a comment doesn't work. Causes an almost-blank page.) : Sure. I'll look-after it tomorrow.
• 2 years, 8 months ago by Luc Saffre about #5440 (Changing the ticket of a comment doesn't work. Causes an almost-blank page.) : @8lurry do you want to take this ticket now? Anyway i must leave now for a few hours.
• 2 years, 8 months ago by Luc Saffre about #5440 (Changing the ticket of a comment doesn't work. Causes an almost-blank page.) : The choices view always looks up the master instance from the contenttypes table. So the action request there has an invalid master instance. This usually doesn't disturb because this master instance is not used much. But when mk is bigger than 110 it raises an error because Lino Noi has only 110 ro...
• 2 years, 8 months ago by Luc Saffre about #5440 (Changing the ticket of a comment doesn't work. Causes an almost-blank page.) : Ha! Here is how to reproduce it in noi1r: in lino_noi/lib/noi/fixtures/demo.py on line 335 change the number of demo tickets from 100 to 200, run pm prep, then sign in, go on a ticket with id bigger than 110, create a comment, click on that comment, and then try to change the ticket.
• 2 years, 8 months ago by Luc Saffre about #5440 (Changing the ticket of a comment doesn't work. Causes an almost-blank page.) : The Ajax call is correct, so the bug is on the server side. I am diving into this.
• 2 years, 8 months ago by Luc Saffre about #5440 (Changing the ticket of a comment doesn't work. Causes an almost-blank page.) : Hey, the issue is still there even after upgrading Jane. Starts to get interesting...
• 2 years, 8 months ago by Luc Saffre about #5440 (Changing the ticket of a comment doesn't work. Causes an almost-blank page.) : OK I will make a quick upgrade to Jane now.
• 2 years, 8 months ago by Luc Saffre about #5440 (Changing the ticket of a comment doesn't work. Causes an almost-blank page.) : The issue is indeed only on Jane. So let's try again after the next upgrade.
• 2 years, 8 months ago by Luc Saffre about #5440 (Changing the ticket of a comment doesn't work. Causes an almost-blank page.) : The traceback is the same as yesterday. Seems that the value of mt is wrong: mt=36. I said "pm show contenttypes.ContentType" on jane and 36 is tickets.Ticket. But for some reason Lino is trying to look up the ticket number( 5429) from the ContentType.
• 2 years, 8 months ago by Luc Saffre about #5440 (Changing the ticket of a comment doesn't work. Causes an almost-blank page.) : It happens in Jane on #5429. The (currently) last comment there is "15 hours ago by 8lurry (2 replies) : kuurunner says low disk space. see pipeline job". Click on the time indication ("15 hours ago") to open that comment. Then, in the More tab, try to select another ticket.
• 2 years, 8 months ago by Luc Saffre about #5440 (Changing the ticket of a comment doesn't work. Causes an almost-blank page.) : Indeed me too I can't reproduce it in noi1r. I will now try to reproduce it in Jane, where I had it yesterday.
• 2 years, 8 months ago by Sharif Mehedi about #5440 (Changing the ticket of a comment doesn't work. Causes an almost-blank page.) : It seem to work fine locally.
• 2 years, 8 months ago by Luc Saffre about #5440 (Changing the ticket of a comment doesn't work. Causes an almost-blank page.) : The almost-blank page comes because the server has an exception when trying to answer the /choices/ ajax request:
  
  Internal Server Error: /choices/comments/CommentsByRFC/owner_id Exception at /choices/comments/CommentsByRFC/owner_id There's no ContentType with primary key '5429' Request Method: GE...
• 2 years, 8 months ago by Luc Saffre about #5440 (Changing the ticket of a comment doesn't work. Causes an almost-blank page.) : How to reproduce: in the More tab of the detail view of a comment, try to select another ticket.
• 2 years, 8 months ago by Luc Saffre about #5440 (Changing the ticket of a comment doesn't work. Causes an almost-blank page.) : Created new Ticket #5440@dev (Changing the ticket of a comment doesn't work. Causes an almost-blank page.).