by Sharif Mehedi · in Developers · assigned to Sharif Mehedi

Summary

Children

Comments

• 2 years, 4 months ago by Luc Saffre about #5654 (remove deprecated js event.keyCode with e.key or e.code) : The welfare test suite is now again okay (the failure in welfare/docs/specs/topics/autoevents.rst:110 is another ticket... namely #5544 (The welfare test suite fails due to translation issues)
• 2 years, 4 months ago by Luc Saffre about #5654 (remove deprecated js event.keyCode with e.key or e.code) : I manually tested Ctrl-P and Ctrl-X keys in gerd, they both work as expected.
• 2 years, 4 months ago by Luc Saffre about #5654 (remove deprecated js event.keyCode with e.key or e.code) (1 reply) : Seems that the change in Model.disabled_fields() also causes an exception "RelatedObjectDoesNotExist: Guest has no event" when you sign in as robin in demo project "gerd" (which is in the welfare repository).
  
• 2 years, 4 months ago by Sharif Mehedi about #5654 (remove deprecated js event.keyCode with e.key or e.code) : The following [url gitlab.com/lino-framework/xl/-/commit/db777e702ae6e2ee808f3efe89de188422b0c5d8 change] seem to let pass the welfare test suite. @luc, can you confirm that the change is ok?
• 2 years, 4 months ago by Sharif Mehedi about #5654 (remove deprecated js event.keyCode with e.key or e.code) : I worked on the book test suite for Model.disabled_fields. But welfare test suite fails, and even fails to load the main_html
• 2 years, 4 months ago by Luc Saffre about #5654 (remove deprecated js event.keyCode with e.key or e.code) (1 reply) : @8lurry, you recent change in Model.disabled_fields() causes at least one failure in the book test suite. Can you try to fix this?
• 2 years, 4 months ago by Sharif Mehedi about #5654 (remove deprecated js event.keyCode with e.key or e.code) : Created new Ticket #5654 (remove deprecated js event.keyCode with e.key or e.code).