#5844 (The ↗ of the phantom row should open an insert window)

by Luc Saffre · in Developers · assigned to Luc Saffre

Summary

Use case: avanti2, the "Comments" tab of a client. The end users explicitly want CommentsByRFC to be in a "tabular" view by default. We do this by saying CommentsByRFC.default_display_modes = {None: constants.DISPLAY_MODE_GRID} in /avanti/lino_avanti/lib/avanti/models.py

This works well, BUT adding a new comment is not intuitive because of two "small" problems: (1) the ↗ of the phantom row should open an insert window (right now it just causes a blank window) and (2) Clicking on the body of the phantom row does start the editor, BUT it's difficult to submit because neither Ctrl+S nor TAB do anything meaningful. (3) And we should probably deactivate the toolbar of the editor when it is used inside a grid.

Children

Comments

1 year, 9 months ago by Luc Saffre about #5844 (The ↗ of the phantom row should open an insert window) : Yes, this was a [url gitlab.com/lino-framework/lino/-/commit/0443fdc4c41296a8017ec46c88e5bf467a2aea5e one-line change in lino.core.actions].
1 year, 9 months ago by Luc Saffre about #5844 (The ↗ of the phantom row should open an insert window) : I take this because it is caused by the Python (application) code and I'd like to understand.
1 year, 9 months ago by Luc Saffre about #5844 (The ↗ of the phantom row should open an insert window) : One detail yet: In avanti2, in the comments panel of a client, when i inserted a new comment, after submitting, the grid does not get refreshed. Indeed the POST response does not contain refresh_all=True.
1 year, 9 months ago by Sharif Mehedi about #5844 (The ↗ of the phantom row should open an insert window) : This feature works now. I am closing this ticket.
1 year, 9 months ago by Luc Saffre about #5844 (The ↗ of the phantom row should open an insert window) : avanti2 is a project in the book, you should be able to see my other problems there.
1 year, 9 months ago by Luc Saffre about #5844 (The ↗ of the phantom row should open an insert window) (1 reply) : Indeed, there it works. Ha! it occurs only in slave panels! For example in noi1r go to Configure->Places->Countries, open the detail of a country, then, then try to insert a place in that country.
1 year, 9 months ago by Sharif Mehedi about #5844 (The ↗ of the phantom row should open an insert window) : I just confirmed that it works on noi1r tickets.AllTickets table.
1 year, 9 months ago by Luc Saffre about #5844 (The ↗ of the phantom row should open an insert window) : And Ctrl+S or TAB should end the editor.
1 year, 9 months ago by Luc Saffre about #5844 (The ↗ of the phantom row should open an insert window) (1 reply) : I cannot confirm that it works. When I click on the ↗ of the phantom row, I get a JS error "Uncaught (in promise) TypeError: can't convert null to object" in SiteContext.jsx:154:23, which is: Object.assign(params, c.history.getState(storeKey) || {});
1 year, 9 months ago by Sharif Mehedi about #5844 (The ↗ of the phantom row should open an insert window) : React now opens a insert window for ↗️ in the phantom row. also the editor header is no more available on a table window. see [url gitlab.com/lino-framework/react/-/commit/59f5f4513602e6acd30c48fe4c2cf6aa7068c61c commit]. And I am closing this ticket.
1 year, 9 months ago by Luc Saffre about #5844 (The ↗ of the phantom row should open an insert window) : Created new Ticket #5844 (The ↗ of the phantom row should open an insert window).