by Luc Saffre · in Developers · assigned to Luc Saffre

Summary

Children

Comments

• 1 year, 3 months ago by Luc Saffre about #6202 ("Tickets to work" has its insert button (+) duplicated in the dashboard) : The test suites now pass and I published my changes.
• 1 year, 3 months ago by Luc Saffre about #6202 ("Tickets to work" has its insert button (+) duplicated in the dashboard) : TODO: there are only 2 failures left...
• 1 year, 3 months ago by Luc Saffre about #6202 ("Tickets to work" has its insert button (+) duplicated in the dashboard) : The book test suite now has 22 failures. I'll work on them now.
• 1 year, 3 months ago by Luc Saffre about #6202 ("Tickets to work" has its insert button (+) duplicated in the dashboard) : Hey, that's cool! I like this change!
• 1 year, 3 months ago by Sharif Mehedi about #6202 ("Tickets to work" has its insert button (+) duplicated in the dashboard) : plain toolbar buttons are now visible at SlaveSummaryPanel Panel headers.
• 1 year, 3 months ago by Luc Saffre about #6202 ("Tickets to work" has its insert button (+) duplicated in the dashboard) : The 24d8 variant displays correctly even on my phone. Change help button symbol to phone-friendly variant ⓘ.
• 1 year, 3 months ago by Luc Saffre about #6202 ("Tickets to work" has its insert button (+) duplicated in the dashboard) (1 reply) : Oops the new help button symbol does'nt render correctly on my phone.
• 1 year, 3 months ago by Luc Saffre about #6202 ("Tickets to work" has its insert button (+) duplicated in the dashboard) : In react I extended the ApiList.get() method when fmt=json to add a key "plain_toolbar", which contains these buttons. The frontend does not yet use this information. @8lurry let's play on this together.
• 1 year, 3 months ago by Luc Saffre about #6202 ("Tickets to work" has its insert button (+) duplicated in the dashboard) : As a side effect I changed the button_text of the OpenHelpWindow action from "?" to "🛈". Because the "?" behind each dashboard header did not always look like a help button.
• 1 year, 3 months ago by Luc Saffre about #6202 ("Tickets to work" has its insert button (+) duplicated in the dashboard) : Or rather than telling Actor.get_table_as_list() whether or not we want an insert button, a slave panel might act like the dashboard: render the plain_toolbar_buttons() it its header. In the following screenshot, the (+) button would be together with the help button behind the heading ("Comments"). ...
• 1 year, 3 months ago by Luc Saffre about #6202 ("Tickets to work" has its insert button (+) duplicated in the dashboard) : En passant I discovered #6203 (ar.is_on_main_actor is not used anywhere, right?).
• 1 year, 3 months ago by Luc Saffre about #6202 ("Tickets to work" has its insert button (+) duplicated in the dashboard) (1 reply) : The first one is added by dashboard.DashboardItem.render_request() together with the other ar.plain_toolbar_buttons(). And this is the one we wnat to keep. The second one is added by Actor.get_table_as_list(). We don't want it in the dashboard, but we *do* want it in a slave panel.
• 1 year, 3 months ago by Luc Saffre about #6202 ("Tickets to work" has its insert button (+) duplicated in the dashboard) : Created new Ticket #6202 ("Tickets to work" has its insert button (+) duplicated in the dashboard).