◄ ► | Edit | Home | Admin | en de fr et | Sign in

#6285 (Visually editable images)

by Luc Saffre · in Developers · assigned to Sharif Mehedi

Summary

Children

Comments

  • 1 year, 1 month ago by Luc Saffre about #6285 (Visually editable images) : I pushed my changes for this ticket (in lino and book).
  • 1 year, 1 month ago by Luc Saffre about #6285 (Visually editable images) : I'm repairing the book test suite and encounter questions about how to handle the memo.Mention. Now that an embedded image becomes an uploads.Upload row, don't we want to see it in the "Mentioned from" panel? Yes we would, but it's a challenge because the memo.Mention approach is originally a part o...
  • 1 year, 1 month ago by Sharif Mehedi about #6285 (Visually editable images) : Yesterday I published some changes in lino and now I published on react, some related changes.
  • 1 year, 1 month ago by Luc Saffre in reply to Luc Saffre about #6285 (Visually editable images) : We could then get rid of bootstrap completely. Why not. I'd try to leave it there as a plugin attribute publisher.Plugin.use_bootstrap.
  • 1 year, 1 month ago by Luc Saffre about #6285 (Visually editable images) (1 reply) : And if we say that publisher requires react (i.e. doesn't work with extjs)? It would be an acceptable condition.
  • 1 year, 1 month ago by Sharif Mehedi about #6285 (Visually editable images) : With modified css, the blotformatter2 behave unexpectedly. Not sure what would be the optimal solution.
  • 1 year, 1 month ago by Sharif Mehedi about #6285 (Visually editable images) : And we need to have these customize blotformatter2 styles available on react and publisher at the same time.
  • 1 year, 1 month ago by Sharif Mehedi about #6285 (Visually editable images) : All the style entries on blotformatter2 confine to the top level class name "ql-editor" which is unavailable outside of the quill editor and hence the styles added by blotformatter2 doesn't take effect de-facto outside of the editor. To have the styles take effect on publisher pages and previews we ...
  • 1 year, 1 month ago by Luc Saffre in reply to Sharif Mehedi about #6285 (Visually editable images) : Maybe it's a wrong question. The actual issue is where to define CSS classes to be used for images under React/ExtJS and Publisher. Is it possible that we don't need a common CSS file but rather a list of standard class names, and every frontend decides how to implement them? Seems that we need anot...
  • 1 year, 1 month ago by Luc Saffre in reply to Sharif Mehedi about #6285 (Visually editable images) : Good question. Let's split it into a separate ticket #6292 (Move the local.css from react to jinja)
  • 1 year, 1 month ago by Luc Saffre in reply to Sharif Mehedi about #6285 (Visually editable images) : Looks indeed good, but I'm worried about the warning "[!CAUTION] Note that BlotFormatter2 is NOT compatible with React wrapper library (react-quilljs). See Demos below for a working example using the native Quill object with Blotformatter2 and React."
  • 1 year, 1 month ago by Sharif Mehedi about #6285 (Visually editable images) (1 reply) : This one probably is the best solution: www.npmjs.com/package/@enzedonline/quill-blot-formatter2?activeTab=readme will try it tomorrow.
  • 1 year, 1 month ago by Luc Saffre in reply to Sharif Mehedi about #6285 (Visually editable images) : I'm afraid the text alignment isn't enough, it won't make surrounding text float past the image.
  • 1 year, 1 month ago by Sharif Mehedi about #6285 (Visually editable images) (2 replies) : Where to put the css that is common across multiple frontend.
  • 1 year, 1 month ago by Sharif Mehedi about #6285 (Visually editable images) (1 reply) : Quill already has align toolbar button actions which we can use to align an image as we see fit. I have tried to use a more robust plugin but failed to find a compatible one.
  • 1 year, 1 month ago by Luc Saffre about #6285 (Visually editable images) : Next question is: can we get something similar to Blogger.
  • 1 year, 1 month ago by Luc Saffre in reply to Luc Saffre about #6285 (Visually editable images) : This was a false alert. After looking at it again, it worked.
  • 1 year, 1 month ago by Luc Saffre about #6285 (Visually editable images) (1 reply) : I thought that after the upgrade there would be handles for resizing the images on synodalworld.org/p/47 but there aren't...
  • 1 year, 1 month ago by Luc Saffre in reply to Luc Saffre about #6285 (Visually editable images) : In other words, we would no longer replace img tags with embedded data by a memo command, we would just add a property "upload_id" to the image tag: <img src=".../uploads/thumbs/..." upload_id="123"/>
  • 1 year, 1 month ago by Luc Saffre in reply to Luc Saffre about #6285 (Visually editable images) : OTOH, Blogger shows a feasible compromise, and having no visual image editor will be a show stopper even for minimalists.
  • 1 year, 1 month ago by Luc Saffre about #6285 (Visually editable images) (1 reply) : I had a play session in the WordPress playground and on Blogger and my impression is: no we shouldn't try to imitate WP; users who want full control over the layout of their website should use WP or something similar. Images in Lino become memo commands after the first save, and from that moment you...
  • 1 year, 1 month ago by Luc Saffre about #6285 (Visually editable images) (1 reply) : Let's have another brainstormin session about this. Can we add some custom property "upload_id" of the img tag?
  • 1 year, 1 month ago by Luc Saffre about #6285 (Visually editable images) : A memo command like [file 6 class="img-fluid" style="max-width:80%;" title="This is a formatted title."] should get translated to its img tag (without the wrapping a tag?).
  • 1 year, 1 month ago by Luc Saffre about #6285 (Visually editable images) : Created new Ticket #6285 (Editable images).