◄ ► | Bearbeiten | Startseite | Admin | en de fr et | Anmelden

#6292 (Move the local.css from react to jinja)

by Luc Saffre · in Developers · assigned to Luc Saffre

Kurzbeschreibung

Before any change I did some cleanup:

  1. Remove build_site_cache_url() because it is the same as build_media_url().
  2. Remove never_build_site_cache because it is no longer relevant.

Kinder

Kommentare

  • 8 Monate, 4 Wochen ago von Luc Saffre about #6292 (Move the local.css from react to jinja) : The font-size was given in px at some places in local.css, I replaced these values by values in rem.
  • 1 Jahr ago von Luc Saffre Antwort auf Luc Saffre about #6292 (Move the local.css from react to jinja) : Oops, no, the tile_width and background_color settings aren't in system but in jinja (because system isn't always available).
  • 1 Jahr ago von Luc Saffre about #6292 (Move the local.css from react to jinja) (1 Antwort) : Uff! This took me some time. It's now done by core.Renderer.build_js_cache(). It's still being generated once for every language and user_type. And it uses two new settings of the system plugin: tile_width and background_color. It is a part of the core because (a) Lino might support other templating...
  • 1 Jahr ago von Luc Saffre about #6292 (Move the local.css from react to jinja) : Hey, I now thought that build_local_css() should not be in any plugin at all, but directly in Site.build_site_cache(). Because it's theoretically possible that we would use another default templating system than jinja.
  • 1 Jahr ago von Luc Saffre about #6292 (Move the local.css from react to jinja) : Move build_local_css() to Plugin and implement it in Jinaj, and callit in Site.build_site_cache() only once at startup (not as it does right now once for each user type and language).
  • 1 Jahr ago von Luc Saffre Antwort auf Luc Saffre about #6292 (Move the local.css from react to jinja) : It's only after "pm prep". So it is not yet "necessary" (in a demo we could live without it).
  • 1 Jahr ago von Luc Saffre about #6292 (Move the local.css from react to jinja) (1 Antwort) : It is now necessary because runserver in vedi1 has the side effect that local.css isn't yet there until react has been called at least once.
  • 1 Jahr, 1 Monat ago von Luc Saffre about #6292 (Move the local.css from react to jinja) : Created new Ticket #6292 (Move the local.css from react to jinja) as child of #6285 (Visually editable images).